fix resampling leads to Hard to tap #81022

LinXiaoTao · 2021-04-23T02:41:11Z

On Flutter 2.0, enabling resampling will result in hard to tap on Android devices.

I think it was caused by this commit #67080.
When converting PointerUpEvent to PointerMoveEvent(see code 1), buttons are 0(see code 2), so the stopTrackingPointer method is executed(see code 3) and the tap callback is cancelled.

// src/gestures/resampler.dart
if (event is! PointerMoveEvent && event is! PointerHoverEvent) {                                    
  // Add synthetics `move` or `hover` event if position has changed.                                
  // Note: Devices without `hover` events are expected to always have                               
  // `add` and `down` events with the same position and this logic will                             
  // therefor never produce `hover` events.                                                         
  if (position != _position) {                                                                      
    final Offset delta = position - _position; 
    // code 1                                                     
    callback(_toMoveOrHoverEvent(event, position, delta, _pointerIdentifier, sampleTime, wasDown)); 
    _position = position;                                                                           
  }                                                                                                 
  callback(event.copyWith(                                                                          
    position: position,                                                                             
    delta: Offset.zero,                                                                             
    pointer: pointerIdentifier,                                                                     
    timeStamp: sampleTime,                                                                          
  ));                                                                                               
} 

PointerEvent _toMoveEvent(                     
  PointerEvent event,                          
  Offset position,                             
  Offset delta,                                
  int pointerIdentifier,                       
  Duration timeStamp,                          
) { 
  // code 2                                           
  return PointerMoveEvent(                     
    timeStamp: timeStamp,                      
    pointer: pointerIdentifier,                
    kind: event.kind,                          
    device: event.device,                      
    position: position,                        
    delta: delta,                              
    buttons: event.buttons,                    
    obscured: event.obscured,                  
    pressure: event.pressure,                  
    pressureMin: event.pressureMin,            
    pressureMax: event.pressureMax,            
    distanceMax: event.distanceMax,            
    size: event.size,                          
    radiusMajor: event.radiusMajor,            
    radiusMinor: event.radiusMinor,            
    radiusMin: event.radiusMin,                
    radiusMax: event.radiusMax,                
    orientation: event.orientation,            
    tilt: event.tilt,                          
    platformData: event.platformData,          
    synthesized: event.synthesized,            
    embedderId: event.embedderId,              
  );                                           
}

// src/gestures/tap.dart
@override                                                
void handlePrimaryPointer(PointerEvent event) {          
  if (event is PointerUpEvent) {                         
    _up = event;                                         
    _checkUp();                                          
  } else if (event is PointerCancelEvent) {              
    resolve(GestureDisposition.rejected);                
    if (_sentTapDown) {                                  
      _checkCancel(event, '');                           
    }                                                    
    _reset();                                            
  } else if (event.buttons != _down!.buttons) {          
    resolve(GestureDisposition.rejected); 
    // code 3          
    stopTrackingPointer(primaryPointer!);                
  }                                                      
}

google-cla · 2021-04-23T02:41:15Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

flutter-dashboard · 2021-04-23T02:41:15Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

LinXiaoTao · 2021-04-23T02:45:33Z

@googlebot I signed it!

google-cla · 2021-04-23T02:45:47Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

…lt buttons value.(flutter#73286)

LinXiaoTao · 2021-04-23T02:49:59Z

@googlebot I signed it!

xu-baolin · 2021-04-23T09:38:50Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@LinXiaoTao Hi, This needs a test.

LinXiaoTao · 2021-04-23T09:57:45Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.
If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?
Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@LinXiaoTao Hi, This needs a test.

Hi，Does it mean writing test cases?

xu-baolin · 2021-04-23T09:59:29Z

Yes.

LinXiaoTao · 2021-04-24T04:04:10Z

@xu-baolin Hi,Can you help me review the code again.

LinXiaoTao · 2021-04-25T03:51:42Z

@dreveman Hi,Can you help me review the code.

dreveman

Good catch!

packages/flutter/lib/src/gestures/resampler.dart

packages/flutter/test/gestures/resampler_test.dart

dreveman

thanks! looks good after making suggested changes

packages/flutter/lib/src/gestures/resampler.dart

Co-authored-by: David Reveman <david@reveman.com>

google-cla · 2021-04-27T13:14:27Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Co-authored-by: David Reveman <david@reveman.com>

google-cla · 2021-04-27T13:14:36Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Co-authored-by: David Reveman <david@reveman.com>

google-cla · 2021-04-27T13:14:47Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Co-authored-by: David Reveman <david@reveman.com>

google-cla · 2021-04-27T13:14:57Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Co-authored-by: David Reveman <david@reveman.com>

google-cla · 2021-04-27T13:15:12Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

Co-authored-by: David Reveman <david@reveman.com>

google-cla · 2021-04-27T13:15:48Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

dreveman · 2021-04-28T12:30:19Z

Please go ahead and merge this after signing the cla.

LinXiaoTao · 2021-04-28T12:36:08Z

Please go ahead and merge this after signing the cla.

Hi, I have signed cla. Could it be because of your email address in the commit?

LinXiaoTao · 2021-04-28T12:36:38Z

@googlebot I fixed it.

google-cla · 2021-04-28T12:36:48Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

dreveman · 2021-04-28T15:35:24Z

Yes, my alternative email was causing problems. I merged this for you. Thanks for your contribution!

flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Apr 23, 2021

google-cla bot added the cla: no label Apr 23, 2021

fix PointerUpEvent conversion PointerMoveEvent needs to use the defau…

37e619e

…lt buttons value.(flutter#73286)

LinXiaoTao force-pushed the fix-resampling-tap branch from 0df29c4 to 37e619e Compare April 23, 2021 02:49

google-cla bot added cla: yes and removed cla: no labels Apr 23, 2021

feat PointerMoveEvent conversion adds test cases

b0c3c76

dreveman suggested changes Apr 25, 2021

View reviewed changes

packages/flutter/lib/src/gestures/resampler.dart Outdated Show resolved Hide resolved

packages/flutter/test/gestures/resampler_test.dart Outdated Show resolved Hide resolved

packages/flutter/test/gestures/resampler_test.dart Show resolved Hide resolved

fix event conversion may modify the original buttons value.

5840b4a

LinXiaoTao requested a review from dreveman April 26, 2021 02:35

dreveman suggested changes Apr 27, 2021

View reviewed changes

Update packages/flutter/lib/src/gestures/resampler.dart

cb63afd

Co-authored-by: David Reveman <david@reveman.com>

google-cla bot removed the cla: yes label Apr 27, 2021

Update packages/flutter/lib/src/gestures/resampler.dart

3ea7090

Co-authored-by: David Reveman <david@reveman.com>

google-cla bot added the cla: no label Apr 27, 2021

Update packages/flutter/lib/src/gestures/resampler.dart

048a304

Co-authored-by: David Reveman <david@reveman.com>

Update packages/flutter/lib/src/gestures/resampler.dart

92b29a7

Co-authored-by: David Reveman <david@reveman.com>

Update packages/flutter/lib/src/gestures/resampler.dart

10b28df

Co-authored-by: David Reveman <david@reveman.com>

Update packages/flutter/lib/src/gestures/resampler.dart

1ae2278

Co-authored-by: David Reveman <david@reveman.com>

dreveman approved these changes Apr 27, 2021

View reviewed changes

dreveman merged commit 8ddfc80 into flutter:master Apr 28, 2021

duncanmak mentioned this pull request May 2, 2021

[Desktop] PointerUpEvent says 0 for buttons always #81626

Closed

pedromassangocode mentioned this pull request May 13, 2021

Hard to tap when resampling enabled on Samsung Galaxy S20 Ultra #73286

Closed

fix resampling leads to Hard to tap #81022

fix resampling leads to Hard to tap #81022

Uh oh!

Conversation

LinXiaoTao commented Apr 23, 2021 • edited by pedromassangocode Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

google-cla bot commented Apr 23, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

Uh oh!

flutter-dashboard bot commented Apr 23, 2021

Uh oh!

LinXiaoTao commented Apr 23, 2021

Uh oh!

google-cla bot commented Apr 23, 2021

Uh oh!

LinXiaoTao commented Apr 23, 2021

Uh oh!

xu-baolin commented Apr 23, 2021

Uh oh!

LinXiaoTao commented Apr 23, 2021

Uh oh!

xu-baolin commented Apr 23, 2021

Uh oh!

LinXiaoTao commented Apr 24, 2021

Uh oh!

LinXiaoTao commented Apr 25, 2021

Uh oh!

dreveman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dreveman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

google-cla bot commented Apr 27, 2021

Uh oh!

google-cla bot commented Apr 27, 2021

Uh oh!

google-cla bot commented Apr 27, 2021

Uh oh!

google-cla bot commented Apr 27, 2021

Uh oh!

google-cla bot commented Apr 27, 2021

Uh oh!

google-cla bot commented Apr 27, 2021

Uh oh!

dreveman commented Apr 28, 2021

Uh oh!

LinXiaoTao commented Apr 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LinXiaoTao commented Apr 28, 2021

Uh oh!

google-cla bot commented Apr 28, 2021

Uh oh!

dreveman commented Apr 28, 2021

Uh oh!

Uh oh!

LinXiaoTao commented Apr 23, 2021 •

edited by pedromassangocode

Loading

LinXiaoTao commented Apr 28, 2021 •

edited

Loading