Fix error resolution when a completer is already set #81014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
commented
Apr 23, 2021
Comment on lines
337
to
339
| if (stream.completer == null) { | ||
| stream.setCompleter(imageCompleter); | ||
| } |
There was a problem hiding this comment.
Without this, we trip over an assertion error. The test used to be happy because Dart didn't bubble it up to the outter zone handler in the test, but we actually just stopped execution here and didn't do what we think we were doing.
jason-simmons
approved these changes
Apr 23, 2021
dart-bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Apr 23, 2021
… to their parent zone." This reverts commit f0a8b63. Reason for revert: The Flutter SDK issues have been resolved - see flutter/flutter#80969 and flutter/flutter#81014 Original change's description: > Revert "Make throwing Zone.uncaughtError handlers propagate the error to their parent zone." > > This reverts commit 88a351f. > > This broke the Dart SDK -> Flutter Engine roller. Flutter issue at flutter/flutter#80969 > > Change-Id: Idaf255a730c7b6054e6cd929b6770dbe66860151 > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196561 > Reviewed-by: Zach Anderson <zra@google.com> > Commit-Queue: Zach Anderson <zra@google.com> # Not skipping CQ checks because this is a reland. Change-Id: Icd98c550c63160f35cc5da40af7ca6bf2cbf180e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196621 Reviewed-by: Dan Field <dnfield@google.com> Reviewed-by: Siva Annamalai <asiva@google.com> Commit-Queue: Dan Field <dnfield@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80969
The test this modifies was never actually getting into the
FlutterError.onErrorbecause of an assertion aroundsetCompleter. An upcoming dart roll made the whole test blow up. This version now asserts that we get intoFlutterError.onErroras expected, and passes with the Dart revision to the way Zone error handling happens.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.