这是indexloc提供的服务，不要输入任何密码
Skip to content

Allow ios_add2app to be launched without tests #81009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2021
Merged

Allow ios_add2app to be launched without tests #81009

merged 1 commit into from
Apr 23, 2021

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Apr 22, 2021

  1. The ios_add2app project tests were passing, but the app was not launching by itself and was crashing with EarlGrey's app component has been launched without edoPort assigned. You are probably running the application under test by itself, which does not work since the embedded EarlGrey component needs its test counterpart present.. Per EarlGrey 2.0 | Cocoapods | Can't run target app without UITests google/EarlGrey#971, add the EarlGreyStandaloneMode env to the run scheme. The app now launches.
  2. Remove nonexistent Pods-ios_add2appUITests files accidentally included in Migrate ios_add2app_life_cycle to earlgrey 2 and latest iOS SDK #80822

@jmagman jmagman added a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. a: existing-apps Integration with existing apps via the add-to-app flow labels Apr 22, 2021
@jmagman jmagman self-assigned this Apr 22, 2021
@google-cla google-cla bot added the cla: yes label Apr 22, 2021
@jmagman jmagman requested a review from xster April 23, 2021 02:26
@xster
Copy link
Member

xster commented Apr 23, 2021

LGTM

@jmagman jmagman merged commit 4825c63 into flutter:master Apr 23, 2021
@jmagman jmagman deleted the lifecycle-app branch April 23, 2021 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xster xster Awaiting requested review from xster

Assignees

@jmagman jmagman

Labels
a: existing-apps Integration with existing apps via the add-to-app flow a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmagman @xster