这是indexloc提供的服务,不要输入任何密码
Skip to content

Migrate forbidden_from_release_tests to null safety #81006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Apr 22, 2021

dart-lang/sdk#45683 has been resolved and vm_snapshot_analysis has been rolled to a null safe version.
Migrate forbidden_from_release_tests to null safety.

@jmagman jmagman added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Apr 22, 2021
@jmagman jmagman self-assigned this Apr 22, 2021
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 2cc74db into flutter:master Apr 27, 2021
@jmagman jmagman deleted the forbidden branch May 5, 2021 00:17
@jmagman jmagman added the a: null-safety Support for Dart's null safety feature label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: null-safety Support for Dart's null safety feature c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants