Migrate analyze_size to null safety #81002
Conversation
| if (decodedAotSnapshot == null) { | ||
| throwToolExit('AOT snapshot is invalid for analysis'); | ||
| } |
There was a problem hiding this comment.
I can't imagine this ever being null (more likely a FormatException) but just in case. I added a test for it.
| } | ||
| final Map<String, Object?> processedAotSnapshotJson = treemapFromJson(decodedAotSnapshot); | ||
| final _SymbolNode? aotSnapshotJsonRoot = _parseAotSnapshot(processedAotSnapshotJson); | ||
| if (aotSnapshotJsonRoot != null) { |
There was a problem hiding this comment.
I mostly ignored null nodes or missing keys instead of throwing, I can change it if we want to be more aggressive with the expected formatting instead of silently handling it, if preferred.
| import 'test_utils.dart'; | ||
|
|
||
| const String apkDebugMessage = 'A summary of your APK analysis can be found at: '; | ||
| const String iosDebugMessage = 'A summary of your iOS bundle analysis can be found at: '; | ||
| const String runDevToolsMessage = 'flutter pub global activate devtools; flutter pub global run devtools '; | ||
|
|
||
| void main() { | ||
| testWithoutContext('--analyze-size flag produces expected output on hello_world for Android', () async { | ||
| testUsingContext('--analyze-size flag produces expected output on hello_world for Android', () async { |
There was a problem hiding this comment.
This didn't even pass locally on master, it needs the context shutdown hook.
There was a problem hiding this comment.
This is definitely running on CI right? How would it be passing otherwise
There was a problem hiding this comment.
It passes on CI but not locally because the code that uses the context is in getFlutterRoot, which gets bypassed on LUCI because FLUTTER_ROOT is set. I explained it a bit more in #79975.
Really I need to fix the underlying problem, but I've prioritized patching up these integration tests with testUsingContext so I can at least run them locally.
|
This pull request is not suitable for automatic merging in its current state.
|
b77b45b to
e95617d
Compare
Part of #71511