-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[flutter_tools] remove timeout from iOS device startup #81229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flutter_tools] remove timeout from iOS device startup #81229
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for doing this.
This pull request is not suitable for automatic merging in its current state.
|
When a new version of flutter with this? |
This commit is in 2.3.0-1.0.pre, which is currently available on the dev channel. https://flutter.dev/docs/development/tools/sdk/releases?tab=macos. More info in https://github.com/flutter/flutter/wiki/Flutter-build-release-channels. |
Allow Observatory discovery to take as long as it needs on iOS, but print out a warning if it takes longer than 30 seconds
#72161
Dunno If I would say that it "fixes" the above, since that is a bunch of issues tied together