这是indexloc提供的服务,不要输入任何密码
Skip to content

[flutter_tools] remove timeout from iOS device startup #81229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 30, 2021

Conversation

jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Apr 26, 2021

Allow Observatory discovery to take as long as it needs on iOS, but print out a warning if it takes longer than 30 seconds

#72161

Dunno If I would say that it "fixes" the above, since that is a bunch of issues tied together

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 26, 2021
@google-cla google-cla bot added the cla: yes label Apr 26, 2021
@jonahwilliams jonahwilliams marked this pull request as ready for review April 28, 2021 21:51
@jonahwilliams jonahwilliams requested a review from jmagman April 28, 2021 21:51
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this.

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Windows tool_integration_tests_4_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@BringTheChill
Copy link

When a new version of flutter with this?

@jmagman
Copy link
Member

jmagman commented May 11, 2021

This commit is in 2.3.0-1.0.pre, which is currently available on the dev channel. https://flutter.dev/docs/development/tools/sdk/releases?tab=macos. More info in https://github.com/flutter/flutter/wiki/Flutter-build-release-channels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants