Fix bug when resolving entrypoint against package config #81248
Conversation
packages/flutter_tools/test/general.shard/build_system/targets/dart_plugin_registrant_test.dart
Outdated
Show resolved
Hide resolved
| @@ -45,9 +45,9 @@ class DartPluginRegistrantTarget extends Target { | |||
| final String targetFile = environment.defines[kTargetFile] ?? | |||
| environment.fileSystem.path.join('lib', 'main.dart'); | |||
| final File mainFile = environment.fileSystem.file(targetFile); | |||
| final Uri mainFileUri = mainFile.uri; | |||
| assert(packagesFile.path != null); | |||
| final Uri mainFileUri = mainFile.absolute.uri; | |||
| final String mainUri = packageConfig.toPackageUri(mainFileUri)?.toString(); | |||
There was a problem hiding this comment.
What if the main file URI is not in any package?
There was a problem hiding this comment.
i.e. flutter run --target some/absolute/path/test/test_foo.dart
There was a problem hiding this comment.
Do we validate the target earlier?
There was a problem hiding this comment.
Thats not an invalid target though - you'd need to fallback to embedding an absolute URI
There was a problem hiding this comment.
I'm not quite sure what you mean - if the package config fails to resolve the absolute file URI to a package URI, it only means that the file was not under any of the defined package roots. Its still an otherwise valid target file
There was a problem hiding this comment.
ah I see what you mean, import 'package:<package-name>/some/absolute/path/test/test_foo.dart in this case, right?
There was a problem hiding this comment.
For example:
import 'file:///C:/Users/Jonah/flutter/packages/flutter_tools/bin/flutter_tools.dart';There was a problem hiding this comment.
This is totally valid (well, on my computer at least)
There was a problem hiding this comment.
👍 I cleaned up the test file a bit, and added the new test. PTAL
…/dart_plugin_registrant_test.dart Co-authored-by: Jonah Williams <jonahwilliams@google.com>
It should use the target's absolute path URI as opposed to the relative one.
The relative path produces
nullin all cases.