-
Notifications
You must be signed in to change notification settings - Fork 28.9k
Add benchmark for number of GCs in animated GIF #81240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like the checks are unhappy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once checks are happy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this adding more benchmarking tasks to the existing macrobenchmarks app? Can we keep doing this, or do they need to be split into separate devicelab tasks
@jonahwilliams - yes it is. I don't know the answer to that question though - @keyonghan or @godofredoc might have thoughts. |
|
Actually, this adds a test to the Macrobenchmarks application, but I don't think it adds a definition of where to run it. That's changed since I last did this. |
@christopherfujino do you know why the test failure https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8848843484897376256/+/steps/run_test.dart_for_framework_tests_shard_and_subshard_misc/0/logs/stdout/0#L13293_0 is happening on this patch? IT seems unrelated to me, but rebasing to head doesn't seem to have helped. |
The test is now disabled on HEAD (see tree-status chat), so rebasing on master should now fix it. |
I've also added this to its own builder. @jonahwilliams to your question, we run the macrobenchmarks app in a bunch of tasks, each isolated to its own test. |
The builder configuration needs to be added in flutter/infra first before enabling here in prod_builders.json, otherwise test will not be triggered. |
I'll open the infra PR shortly. |
Benchmark for #80702
This does not improve the image, but adds some new categories to the timeline summary we send to the perf dashboard and a test that specifically focuses on animating a GIF for a set number of frames.