这是indexloc提供的服务,不要输入任何密码
Skip to content

Add benchmark for number of GCs in animated GIF #81240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 27, 2021

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Apr 26, 2021

Benchmark for #80702

This does not improve the image, but adds some new categories to the timeline summary we send to the perf dashboard and a test that specifically focuses on animating a GIF for a set number of frames.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Apr 26, 2021
@google-cla google-cla bot added the cla: yes label Apr 26, 2021
@goderbauer
Copy link
Member

Looks like the checks are unhappy.

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once checks are happy

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this adding more benchmarking tasks to the existing macrobenchmarks app? Can we keep doing this, or do they need to be split into separate devicelab tasks

@dnfield
Copy link
Contributor Author

dnfield commented Apr 26, 2021

@jonahwilliams - yes it is. I don't know the answer to that question though - @keyonghan or @godofredoc might have thoughts.

@godofredoc
Copy link
Contributor

question though - @keyonghan or @godofredoc might have thoughts
Ideally we should prefer more tasks with less execution time over less tasks with longer execution times. This will allow us to make more efficient use of resources when we increase the devicelab capacity.

@dnfield
Copy link
Contributor Author

dnfield commented Apr 26, 2021

Actually, this adds a test to the Macrobenchmarks application, but I don't think it adds a definition of where to run it. That's changed since I last did this.

@dnfield
Copy link
Contributor Author

dnfield commented Apr 27, 2021

@christopherfujino do you know why the test failure https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8848843484897376256/+/steps/run_test.dart_for_framework_tests_shard_and_subshard_misc/0/logs/stdout/0#L13293_0 is happening on this patch? IT seems unrelated to me, but rebasing to head doesn't seem to have helped.

@goderbauer
Copy link
Member

The test is now disabled on HEAD (see tree-status chat), so rebasing on master should now fix it.

@dnfield
Copy link
Contributor Author

dnfield commented Apr 27, 2021

I've also added this to its own builder. @jonahwilliams to your question, we run the macrobenchmarks app in a bunch of tasks, each isolated to its own test.

@keyonghan
Copy link
Contributor

The builder configuration needs to be added in flutter/infra first before enabling here in prod_builders.json, otherwise test will not be triggered.

@dnfield
Copy link
Contributor Author

dnfield commented Apr 27, 2021

I'll open the infra PR shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants