[flutter_tools] add support for --bundle-sksl-path to flutter run / flutter drive
#80885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
commented
Apr 21, 2021
| @@ -824,7 +824,7 @@ class PerfTestWithSkSL extends PerfTest { | |||
| await _generateSkSL(); | |||
|
|
|||
| // Build the app with SkSL artifacts and run that app | |||
| final String observatoryUri = await _buildAndRun(); | |||
There was a problem hiding this comment.
I did verify that this works locally too 😄
jmagman
reviewed
Apr 21, 2021
| @@ -824,7 +824,7 @@ class PerfTestWithSkSL extends PerfTest { | |||
| await _generateSkSL(); | |||
|
|
|||
| // Build the app with SkSL artifacts and run that app | |||
| final String observatoryUri = await _buildAndRun(); | |||
| final String observatoryUri = await _runApp(skslPath: _skslJsonFileName); | |||
There was a problem hiding this comment.
appBinary doesn't need to be passed in anymore?
There was a problem hiding this comment.
Instead of building the apk and then running the prebuilt app to work around run not accepting --bundle-sksl-path, we can now just pass the arg to run and have it build the correct app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80840
All of the plumbing was already there, just needed to wire it up.