这是indexloc提供的服务，不要输入任何密码
Skip to content

Modified TabBar.preferredSize to remove hardcoded knowledge about child Tab. #80792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2021
Merged

Modified TabBar.preferredSize to remove hardcoded knowledge about child Tab. #80792

merged 1 commit into from
Apr 23, 2021

Conversation

chinmoy12c
Copy link
Member

TabBar should not have knowledge of Tab per the style guide.

Discovered in #80237
More context from discussion here: https://discord.com/channels/608014603317936148/608021234516754444/832708012937838602

Fixes: #80596

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 20, 2021
@google-cla google-cla bot added the cla: yes label Apr 20, 2021
@HansMuller HansMuller requested a review from Piinks April 22, 2021 23:50
@Piinks Piinks added a: quality A truly polished experience c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. labels Apr 23, 2021
Piinks
Piinks reviewed Apr 23, 2021
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thank you for taking this on! Just a small nit. :)

@chinmoy12c chinmoy12c force-pushed the issue_80596 branch 3 times, most recently from 511ca79 to 4b16da0 Compare April 23, 2021 20:41
Piinks
Piinks approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution! 🎉

@fluttergithubbot fluttergithubbot merged commit 321aa45 into flutter:master Apr 23, 2021
@chinmoy12c chinmoy12c mentioned this pull request Apr 24, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piinks Piinks Piinks approved these changes

Assignees
No one assigned
Labels
a: quality A truly polished experience c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TabBar.preferredSize should not check for Tab child Type
3 participants
@chinmoy12c @Piinks @fluttergithubbot