这是indexloc提供的服务,不要输入任何密码
Skip to content

Updated the OutlinedButton class API doc #80454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2021

Conversation

HansMuller
Copy link
Contributor

Clarified the meaning of ButtonStyle.shape and ButtonStyle.side for OutlinedButton per #78597 (comment).

Fixes #78597

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 14, 2021
@google-cla google-cla bot added the cla: yes label Apr 14, 2021
@HansMuller HansMuller requested a review from darrenaustin April 14, 2021 19:34
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Hixie
Copy link
Contributor

Hixie commented Apr 14, 2021

test-exempt: documentation change

@HansMuller HansMuller force-pushed the outlined_button_side_api_doc branch from d9bd630 to aad4e8f Compare April 14, 2021 21:37
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@HansMuller HansMuller merged commit 2f1d034 into flutter:master Apr 15, 2021
@HansMuller HansMuller deleted the outlined_button_side_api_doc branch April 15, 2021 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OutlinedButton shape does not apply border properties from RoundedRectangleBorder.side
4 participants