Re-land "Added MaterialState.scrolledUnder and support in AppBar.backgroundColor" #80395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rami-a
approved these changes
Apr 14, 2021
| /// | ||
| /// If this color is a [MaterialStateColor] it will be resolved against | ||
| /// [MaterialState.scrolledUnder] when the content of the app's | ||
| /// primary scrollable overlaps the app bar. |
There was a problem hiding this comment.
Oh I think you also need to update the documentation for AppBar's backgroundColor property
There was a problem hiding this comment.
Good point, will do.
039811c to
b0be096
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reland #79999 which was reverted in #80380.
This version of the PR corrects internal Google failures reported in b/185192049 and re-tested in cl/368255039.