这是indexloc提供的服务,不要输入任何密码
Skip to content

create SDK package allowlist for core packages #80318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 16, 2021

Conversation

jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Apr 12, 2021

FYI @Hixie @natebosch @jakemac53

The original context for this PR was the accidental inclusion of the test_core dep in the integration_test dependency. If you would prefer different Dart team contact info or a more detailed accounting of the current packages please let me know.

This only covers the core packages since dependencies in the tool or integration_test do not really affect end users - though they do constraint the overall version solving

Fixes #74070

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Apr 12, 2021
@google-cla google-cla bot added the cla: yes label Apr 12, 2021
@jonahwilliams jonahwilliams marked this pull request as ready for review April 13, 2021 01:52
@jonahwilliams jonahwilliams requested a review from Hixie April 13, 2021 02:10
Copy link
Contributor

@Hixie Hixie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams merged commit f6f59c5 into flutter:master Apr 16, 2021
@jonahwilliams jonahwilliams deleted the package_allowlist branch April 16, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Flutter SDK packages allowlist and use it to prevent accidentally adding new dependencies
2 participants