这是indexloc提供的服务，不要输入任何密码
Skip to content

Migrate dev/integration_tests/web to null safety #80625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2021
Merged

Migrate dev/integration_tests/web to null safety #80625

merged 1 commit into from
Apr 21, 2021

Conversation

Abhishek01039
Copy link
Contributor

@Abhishek01039 Abhishek01039 commented Apr 17, 2021 •
edited
Loading

I have migrated dev/integration_tests/web with null safety.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Apr 17, 2021
@google-cla google-cla bot added the cla: yes label Apr 17, 2021
@Abhishek01039 Abhishek01039 changed the title MIgrate dev/integration_tests/web to null safety Migrate dev/integration_tests/web to null safety Apr 17, 2021
@Abhishek01039
Copy link
Contributor Author

Hello @jmagman
can you please review this PR?
Thanks

jmagman
jmagman approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build tests exercising this passed, LGTM.

@fluttergithubbot fluttergithubbot merged commit 0de20a3 into flutter:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmagman jmagman jmagman approved these changes

Assignees
No one assigned
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Abhishek01039 @jmagman @fluttergithubbot