Fix problem with right-clicking on a right-to-left selection #80186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LongCatIsLooong
approved these changes
Apr 14, 2021
| @@ -487,6 +487,48 @@ void main() { | |||
| expect(renderEditable.selectPositionAtCalled, isTrue); | |||
| }); | |||
|
|
|||
| testWidgets('TextSelectionGestureDetectorBuilder right click', (WidgetTester tester) async { | |||
There was a problem hiding this comment.
Also could you add a comment to this test that says it's a regression test for #80119, for posterity?
There was a problem hiding this comment.
Thank you for the review! Both issues are now fixed.
|
What the status of this PR? We need this PR.... Please... |
|
I'm not sure if the test failures (especially the customer testing failures) are flakes. @ludwiktrammer could you sync the PR to |
|
@LongCatIsLooong Done. This time the checks have passed successfully :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80119, #79592. Right clicking on a selection that was created from right-to-left will now work the same as left clicking on a selection that was created from left-to-right.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.