这是indexloc提供的服务，不要输入任何密码
Skip to content

Modified DataRow to be disabled when onSelectChanged is not set #80184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2021
Merged

Modified DataRow to be disabled when onSelectChanged is not set #80184

merged 1 commit into from
Apr 20, 2021

Conversation

chinmoy12c
Copy link
Member

DataRow receives focus even when onSelectChanged is null. This change enables the user to override this behavior and prevent DataRow to receive focus by default.

List which issues are fixed by this PR. You must list at least one issue.
Fixes: #79800
Fixes: #74022

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Apr 10, 2021
@google-cla google-cla bot added the cla: yes label Apr 10, 2021
@chinmoy12c chinmoy12c force-pushed the issue_79800 branch 2 times, most recently from 437f9da to 27a43bc Compare April 14, 2021 07:21
@HansMuller HansMuller requested a review from gspencergoog April 15, 2021 23:59
gspencergoog
gspencergoog approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Please correct the test description, and then this is ready to go.

@chinmoy12c
Modified DataRow to be disabled when
8b82000 
onSelectChanged is not set
@chinmoy12c chinmoy12c changed the title Modified DataRow to prevent receiving focus by default Modified DataRow to be disabled when onSelectChanged is not set Apr 20, 2021
@gspencergoog gspencergoog merged commit 430c57e into flutter:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DataTable DataRow without onSelectChange still receives hover visuals on web [proposal] provide a way to prevent DataRow to receive focus
2 participants
@chinmoy12c @gspencergoog