Added ButtonStyle.maximumSize #80087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrenaustin
approved these changes
Apr 9, 2021
| @@ -159,18 +160,29 @@ class ButtonStyle with Diagnosticable { | |||
| /// | |||
| /// The size of the rectangle the button lies within may be larger | |||
| /// per [tapTargetSize]. | |||
| /// | |||
| /// This value must be less than or equal to [maximumSize]. | |||
There was a problem hiding this comment.
Where is this enforced?
There was a problem hiding this comment.
In the _ButtonStyleStat.build() expression that builds a BoxConstraints object:
BoxConstraints effectiveConstraints = resolvedVisualDensity.effectiveConstraints(
BoxConstraints(
minWidth: resolvedMinimumSize!.width,
minHeight: resolvedMinimumSize.height,
maxWidth: resolvedMaximumSize!.width,
maxHeight: resolvedMaximumSize.height,
),
);If you pass invalid minimum/maximumSize values you get a pretty obvious error from the BoxConstraints constructor.
| /// A [Size.infinite] or null value for this property means that | ||
| /// the button's maximum size is not constrained. | ||
| /// | ||
| /// This value must be greater than or equal to [minimumSize]. |
There was a problem hiding this comment.
Where is this enforced?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a ButtonStyle maximumSize property. Its default value is Size.infinite for TextButton, ElevatedButton, OutlinedButton, i.e. none of the buttons constrain their maximum size by default.