Migrate persistent_tool_state to null safety #80085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
commented
Apr 8, 2021
Comment on lines
103
to
105
| final String? versionKey = _versionKeyFor(channel); | ||
| assert(versionKey != null); | ||
| return _config.getValue(versionKey) as String; | ||
| return _config.getValue(versionKey!) as String?; |
There was a problem hiding this comment.
Is there any way to mark that the getter returns a nullable but the setter requires a nonnull value?
There was a problem hiding this comment.
I think that sort of thing is frowned upon.
There was a problem hiding this comment.
I was frowning the whole time.
There was a problem hiding this comment.
Now the getters and setters are named something slightly different.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #71511