这是indexloc提供的服务，不要输入任何密码
Skip to content

Disable win_gradle_plugin_light_apk_test. #80083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 8, 2021
Merged

Disable win_gradle_plugin_light_apk_test. #80083

merged 2 commits into from
Apr 8, 2021

Conversation

godofredoc
Copy link
Contributor

Bug: #80056

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Apr 8, 2021
@google-cla google-cla bot added the cla: yes label Apr 8, 2021
@godofredoc godofredoc requested review from gaaclarke and jmagman April 8, 2021 21:28
@jmagman
Copy link
Member

jmagman commented Apr 8, 2021 •
edited
Loading

Can mac_gradle_plugin_light_apk_test be turned back on and revert the prod part of #80072? I don't see the mac one failing, only the Windows one.

@godofredoc
Copy link
Contributor Author

turned back on

done

jmagman
jmagman approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@godofredoc godofredoc merged commit 71e99d2 into flutter:master Apr 8, 2021
This was referenced Apr 8, 2021
Closed
Merged
@godofredoc godofredoc deleted the flaky_gradle_plugin branch October 18, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmagman jmagman jmagman approved these changes

@gaaclarke gaaclarke Awaiting requested review from gaaclarke

Assignees
No one assigned
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@godofredoc @jmagman