Expose packagePath as a getter in FlutterCommand.
#80026
Conversation
So that it can be overridden internally.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Can you leave a doc comment on packagesFilePath? At least so that we know it is overriden in case we forget in 1+ years.
I would also like a simple test case that shows this still works. You assert that an overriden and fixed packages file path is used for the build info instead of the field passed via the command line?
Also renamed packagesFilePath to packagesPath since it is more commonly used in the code base.
|
Added test and comment. Also renamed PTAL, thanks! |
packageFilePath as a getter in FlutterCommand.packagePath as a getter in FlutterCommand.
So that it can be overridden internally.