这是indexloc提供的服务,不要输入任何密码
Skip to content

Catch and display version check errors during doctor #44868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Nov 14, 2019

Description

Catch and display version check issues instead of crashing.

New text:

Doctor summary (to see all details, run flutter doctor -v):
[!] Flutter (Channel unknown, v0.0.0-unknown, Mac OS X 10.14.6 18G87, locale en-US)
    ✗ Command exited with code 69: git -c log.showSignature=false log -n 1 --pretty=format:%ad --date=iso
      Standard error: 
      Agreeing to the Xcode/iOS license requires admin privileges, please run “sudo xcodebuild -license” and then retry this command.

Related Issues

Fixes #28939

Tests

Added new doctor_test.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@jmagman jmagman requested a review from zanderso November 14, 2019 01:21
@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 14, 2019
@jmagman jmagman added the a: first hour The first hour of using Flutter label Nov 14, 2019
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM NICE

Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jmagman jmagman mentioned this pull request Nov 19, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a: first hour The first hour of using Flutter tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flutter doctor crashes: Agreeing to the Xcode/iOS license requires admin privileges
5 participants