Don't allow Disabled InkWells to be focusable #43848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64f3d1e to
8cd4743
Compare
shihaohong
reviewed
Oct 31, 2019
8cd4743 to
49f09ee
Compare
49f09ee to
fe52197
Compare
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
Makes sure that disabled InkWell/InkResponse and widgets that use them don't allow themselves to be focused. ListTile, PopupMenu, and Stepper were not setting canRequestFocus properly on the InkWell, and InkWell was allowing focus even if it was disabled (it was basically just relying on the containing widget to set canRequestFocus properly). Now InkWell must both be enabled (have an onTap or similar) and have canRequestFocus set to true.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes sure that disabled
InkWell/InkResponseand widgets that use them don't allow themselvesto be focused.
ListTile,PopupMenu, andStepperwere not settingcanRequestFocusproperly on theInkWell, andInkWellwas allowing focus even if it was disabled (it was basically just relying on the containing widget to setcanRequestFocusproperly). NowInkWellmust both be enabled (have anonTapor similar) and havecanRequestFocusset to true.Related Issues
Tests
InkWell,ListTile,PopupMenu, andStepper.Breaking Change