Add reloadMethod RPC #43725
Merged
Add reloadMethod RPC #43725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 29, 2019 08:20
jacob314
reviewed
Oct 29, 2019
| throw rpc.RpcException.invalidParams('Invalid \'isolateId\': $isolateId'); | ||
| } | ||
| if (force is! bool) { |
There was a problem hiding this comment.
was this code intentionally removed? seems unrelated.
There was a problem hiding this comment.
This is unreachable in dart 2 ... I couldn't bear to leave it in
There was a problem hiding this comment.
ah yes :) fine to remove.
We must not be running any lints on this code.
jacob314
reviewed
Oct 29, 2019
| // currently in the same way as hot reload, it leaves the tool free | ||
| // to change to a more efficient implementation in the future. | ||
| _peer.registerMethod('reloadMethod', (rpc.Parameters params) async { | ||
| final String isolateId = params['isolateId'].value; |
There was a problem hiding this comment.
throw invalid parameters on the parameters that are required so I know what to pass.
|
Updated to require class, library, method, and methodBody parameters |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This method will allow the tool to replace hot reload with a more efficient implementation specifically for hot UI in the future. For now it delegates to reloadSources.
Note: removed unreachable type error checking