check if libimobiledevice executables exist #43767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| MockCache mockCache; | ||
|
|
||
| setUp(() { | ||
| mockCache = MockCache(); | ||
| }); | ||
|
|
||
| testUsingContext('verifies executables for libimobiledeivce in isUpToDateInner', () async { |
There was a problem hiding this comment.
libimobiledevice spelling
christopherfujino
approved these changes
Oct 29, 2019
| @@ -1102,18 +1102,42 @@ class IosUsbArtifacts extends CachedArtifact { | |||
| 'ios-deploy', | |||
| ]; | |||
|
|
|||
| static const Map<String, List<String>> _kExecutables = <String, List<String>>{ | |||
There was a problem hiding this comment.
Oh, maybe a comment here too, to give some context
added 2 commits
October 29, 2019 16:32
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've been noticing several ArgumentErrors in crash logs from missing libimobiledevice artifacts. In place of a full solution (checksums, cache verification), we can add a check that the specific artifacts exist on disk to the cache update logic.