Mark routes as opaque when added without animation #43756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
reviewed
Oct 29, 2019
| @@ -1754,7 +1754,7 @@ Future<void> main() async { | |||
| routes: routes, | |||
| initialRoute: '/two', | |||
| )); | |||
| expect(find.text('two'), findsOneWidget); | |||
| expect(tester.takeException(), isNull); | |||
There was a problem hiding this comment.
This LGTM. This was the actual intent of the test at the time - I probably either mistook which route actually had which widget, or was just doing this to make sure we didn't fire an assert.
Would it be worth testing here expect(find.text('two'), findsNothing) and expect(find.text('three'), findsOneWidget)?
Also, should we be worried about this breaking internal tests that relied on this behavior?
There was a problem hiding this comment.
Added those expects.
I think we just have to update those tests then. They are relying on a bug. Doing so is easy, see some of the other tests in this PR that I had to update.
chunhtai
reviewed
Oct 29, 2019
chunhtai
approved these changes
Oct 30, 2019
| newEntry.opaque = true; // Does neither trigger an assert nor throw. | ||
| expect(newEntry.opaque, isTrue); | ||
|
|
||
| // The new opaqueness is honored when inserted into an overlay: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prior to this change TransitionRoutes that were added without animation would not properly mark their first OverlayEntry as opaque. This means Flutter was rendering Routes that weren't visible (and those invisible Routes also showed up in the inspector and confused people there). This happened most prominently when the initial routes where added because those always skip their entrance animation.
This change now properly marks the OverlayEntrys of those routes as opaque.
It also modifies OverlayEntry.opaque to allow modifying the opaqueness before the entry is added to an overlay.
Related Issues
Fixes #38038.
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?