Print message and log event when app isn't using AndroidX #42548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
approved these changes
Oct 11, 2019
| } else if (!usesAndroidX) { | ||
| BuildEvent('app-not-using-android-x').send(); | ||
| printStatus('$exclamationMark Your app isn\'t using AndroidX.', emphasis: true); | ||
| printStatus( |
There was a problem hiding this comment.
I think the Flutter style guide says to do this like:
printStatus(
'To avoid potential build failures, you can quickly migrate your app '
'by following the steps on https://goo.gl/CP92wY.',
indent: 4,
);
Codecov Report
@@ Coverage Diff @@
## master #42548 +/- ##
==========================================
- Coverage 60.29% 59.35% -0.95%
==========================================
Files 194 194
Lines 18871 18859 -12
==========================================
- Hits 11379 11194 -185
- Misses 7492 7665 +173
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added the new migration guide: https://flutter.dev/docs/development/androidx-migration.
Now, the tool can start printing a message and logging events when app isn't using AndroidX.
Tests
I added the following tests:
Unit tests
build_apk_test.dartandbuild_appbundle_test.dart.Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Does your PR require Flutter developers to manually update their apps to accommodate your change?