Pass -Ddart.developer.causal_async_stacks=true to frontend_server invocations. #42354
Conversation
…ocations. Bytecode generation will otherwise omit prologue code, causing --causal-async-stacks passed to the VM to behave inconsistently.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| @@ -286,6 +286,7 @@ class KernelCompiler { | |||
| sdkRoot, | |||
| '--strong', | |||
| '--target=$targetModel', | |||
| '-Ddart.developer.causal_async_stacks=true', | |||
There was a problem hiding this comment.
It seems like we need to decide on causal-async-stacks somewhere up in the call chain, not in the compiler itself. Consider passing a bool argument here.
There was a problem hiding this comment.
Added this as a parameter to KernelCompiler/ResidentCompiler, but still always using a default value of true since Flutter has (as-yet) no mode that runs with them off.
| @@ -569,6 +570,7 @@ class ResidentCompiler { | |||
| '--incremental', | |||
| '--strong', | |||
| '--target=$_targetModel', | |||
| '-Ddart.developer.causal_async_stacks=true', | |||
There was a problem hiding this comment.
Ditto - consider adding a bool argument to ResidentCompiler.
|
This should be probably consistent with VM options (flutter/engine#13004) as well as gen_snapshot arguments. /cc @jason-simmons |
Codecov Report
@@ Coverage Diff @@
## master #42354 +/- ##
==========================================
+ Coverage 59.12% 60.06% +0.94%
==========================================
Files 194 194
Lines 18989 18991 +2
==========================================
+ Hits 11227 11407 +180
+ Misses 7762 7584 -178
Continue to review full report at Codecov.
|
…ocations. (flutter#42354) Bytecode generation will otherwise omit prologue code, causing --causal-async-stacks passed to the VM to behave inconsistently.
Bytecode generation will otherwise omit prologue code, causing --causal-async-stacks passed to the VM to behave inconsistently.