AOT support for Linux Desktop I: switch Linux builds to assemble #41612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #41612 +/- ##
==========================================
- Coverage 60.92% 60.19% -0.74%
==========================================
Files 194 194
Lines 18920 18924 +4
==========================================
- Hits 11527 11391 -136
- Misses 7393 7533 +140
Continue to review full report at Codecov.
|
jonahwilliams
commented
Oct 4, 2019
| if (localEngine != null) '--local-engine=$localEngine', | ||
| 'assemble', | ||
| '-dTargetPlatform=$targetPlatform', | ||
| '-dBuildMode=$buildMode', |
There was a problem hiding this comment.
This will fail with non-debug builds for now since there are no profile or release targets.
There was a problem hiding this comment.
Actually, I updated to be hardcoded to debug so it doesn't crash on --release
franciscojma86
approved these changes
Oct 4, 2019
| @@ -18,6 +18,9 @@ Future<void> main(List<String> arguments) async { | |||
| final String localEngine = Platform.environment['LOCAL_ENGINE']; | |||
| final String flutterRoot = Platform.environment['FLUTTER_ROOT']; | |||
|
|
|||
| final String flutterExecutable = path.join( | |||
There was a problem hiding this comment.
Move this after the localEngine check to avoid initializing and exiting early?
| if (localEngine != null) '--local-engine=$localEngine', | ||
| 'assemble', | ||
| '-dTargetPlatform=$targetPlatform', | ||
| '-dBuildMode=$buildMode', |
|
I reverted this, see #42030 |
dnfield
added a commit
that referenced
this pull request
Oct 7, 2019
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
…ble (flutter#41612)" (flutter#42030) This reverts commit 3024053.
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
…ble (flutter#41612)" (flutter#42030)" (flutter#42038) This reverts commit 142a863.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates linux desktop builds (debug only) to use assemble. Preparation for supporting an AOT build through the same mechanism. Removes linux support from unpack command.
#32921