这是indexloc提供的服务，不要输入任何密码
Skip to content

print launching on device message #39748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 3, 2019
Merged

print launching on device message #39748

merged 2 commits into from
Sep 3, 2019

Conversation

jonahwilliams
Copy link
Contributor

Description

Prints launching TARGET on DEVICE_NAME in MODE for the web resident runner. cc @DanTup

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 3, 2019
@jonahwilliams jonahwilliams added platform-web Web applications specifically and removed cla: yes labels Sep 3, 2019
@jonahwilliams jonahwilliams requested a review from DanTup September 3, 2019 15:47
DanTup
DanTup approved these changes Sep 3, 2019
View reviewed changes
Copy link
Contributor

@DanTup DanTup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Starting test runner...
  flutter run debugger (launch on chrome)
    ✓ runs and remains active until told to quit (49815ms)
  1 passing (1m)

Thanks! 👍

@codecov
Copy link

codecov bot commented Sep 3, 2019 •
edited
Loading

Codecov Report

Merging #39748 into master will decrease coverage by 1.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39748      +/-   ##
==========================================
- Coverage   57.36%   56.24%   -1.12%     
==========================================
  Files         194      194              
  Lines       18723    18726       +3     
==========================================
- Hits        10740    10532     -208     
- Misses       7983     8194     +211
Flag Coverage Δ
#flutter_tool 56.24% <100%> (-1.12%) ⬇️
Impacted Files Coverage Δ
...ools/lib/src/build_runner/resident_web_runner.dart 75.53% <100%> (-0.2%) ⬇️
packages/flutter_tools/lib/src/commands/run.dart 20% <0%> (-43%) ⬇️
packages/flutter_tools/lib/src/run_hot.dart 45.57% <0%> (-23.33%) ⬇️
...ackages/flutter_tools/lib/src/resident_runner.dart 37.25% <0%> (-17.73%) ⬇️
...ckages/flutter_tools/lib/src/reporting/events.dart 83.92% <0%> (-14.29%) ⬇️
packages/flutter_tools/lib/src/run_cold.dart 12.34% <0%> (-7.41%) ⬇️
packages/flutter_tools/lib/src/features.dart 82.97% <0%> (-2.13%) ⬇️
packages/flutter_tools/lib/src/context_runner.dart 68.62% <0%> (-1.97%) ⬇️
packages/flutter_tools/lib/src/version.dart 90.9% <0%> (-1.92%) ⬇️
.../flutter_tools/lib/src/runner/flutter_command.dart 78.94% <0%> (-1.76%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc9b614...6b709c1. Read the comment docs.

@jonahwilliams jonahwilliams merged commit d804097 into flutter:master Sep 3, 2019
@jonahwilliams jonahwilliams deleted the print_device_string branch September 3, 2019 19:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yjbanov yjbanov yjbanov approved these changes

@DanTup DanTup DanTup approved these changes

Assignees
No one assigned
Labels
platform-web Web applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jonahwilliams @yjbanov @DanTup @googlebot @fluttergithubbot