这是indexloc提供的服务，不要输入任何密码
Skip to content

Show process error when iOS install fails #38712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2019
Merged

Show process error when iOS install fails #38712

merged 1 commit into from
Aug 20, 2019

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Aug 16, 2019

Description

Print error when iOS device installation fails.
android_device's install_app method already prints out errors on failure.

Related Issues

Fixes #38614.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@jmagman jmagman added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 16, 2019
@jmagman jmagman self-assigned this Aug 16, 2019
@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. While there are exceptions to this rule, if this patch modifies code it is probably not an exception.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@codecov
Copy link

codecov bot commented Aug 16, 2019 •
edited
Loading

Codecov Report

Merging #38712 into master will decrease coverage by 0.2%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38712      +/-   ##
==========================================
- Coverage    56.2%      56%   -0.21%     
==========================================
  Files         195      195              
  Lines       18252    18254       +2     
==========================================
- Hits        10259    10223      -36     
- Misses       7993     8031      +38
Flag Coverage Δ
#flutter_tool 56% <0%> (-0.21%) ⬇️
Impacted Files Coverage Δ
packages/flutter_tools/lib/src/ios/devices.dart 60.16% <0%> (-0.5%) ⬇️
...tter_tools/lib/src/build_system/targets/macos.dart 1.02% <0%> (-40.82%) ⬇️
...ages/flutter_tools/lib/src/test/test_compiler.dart 54.92% <0%> (-15.5%) ⬇️
...ages/flutter_tools/lib/src/commands/build_aot.dart 27.1% <0%> (-12.15%) ⬇️
packages/flutter_tools/lib/src/version.dart 90.73% <0%> (-1.96%) ⬇️
packages/flutter_tools/lib/src/cache.dart 43.5% <0%> (-0.73%) ⬇️
packages/flutter_tools/lib/src/base/logger.dart 82.06% <0%> (-0.39%) ⬇️
packages/flutter_tools/lib/src/vmservice.dart 37.92% <0%> (+0.45%) ⬆️
packages/flutter_tools/lib/src/base/process.dart 80.46% <0%> (+0.78%) ⬆️
packages/flutter_tools/lib/src/build_info.dart 71.58% <0%> (+1.63%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cac8fa5...b382e4f. Read the comment docs.

@jmagman jmagman requested a review from jonahwilliams August 20, 2019 01:24
jonahwilliams
jonahwilliams approved these changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

christopherfujino
christopherfujino approved these changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman merged commit 198c4f1 into flutter:master Aug 20, 2019
@jmagman jmagman deleted the error branch August 20, 2019 17:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Assignees

@jmagman jmagman

Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flutter install doesn't give useful diagnostics on failure
5 participants
@jmagman @fluttergithubbot @christopherfujino @jonahwilliams @googlebot