这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@fluttergithubbot
Copy link
Contributor

Issue link: #175173

@fluttergithubbot fluttergithubbot added the team-engine Owned by Engine team label Sep 10, 2025
@flutter-dashboard flutter-dashboard bot added c: flake Tests that sometimes, but not always, incorrectly pass c: tech-debt Technical debt, code quality, testing, etc. labels Sep 10, 2025
@github-actions github-actions bot removed c: tech-debt Technical debt, code quality, testing, etc. team-engine Owned by Engine team labels Sep 10, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .ci.yaml configuration file to mark the Linux_pixel_7pro static_path_stroke_tessellation_perf__timeline_summary test as flaky by setting bringup: true. This is a temporary measure to prevent the test from blocking CI, with a comment linking to the issue for tracking the underlying flakiness.


# Uses Impeller.
- name: Linux_pixel_7pro static_path_stroke_tessellation_perf__timeline_summary
bringup: true # Flaky https://github.com/flutter/flutter/issues/175173
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve long-term maintainability and ensure this flaky test is eventually re-enabled, it's good practice to add a TODO comment. This serves as a reminder to address the flakiness and remove the bringup: true flag.

    bringup: true # Flaky: https://github.com/flutter/flutter/issues/175173. TODO: Remove this once the test is fixed.

@flar flar added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 10, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Sep 11, 2025
Merged via the queue into flutter:master with commit 689832e Sep 11, 2025
157 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 11, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Sep 12, 2025
flutter/flutter@5a6a1bf...f331a55

2025-09-12 engine-flutter-autoroll@skia.org Roll Dart SDK from a4075f2f670f to 11dedad2d062 (2 revisions) (flutter/flutter#175268)
2025-09-12 engine-flutter-autoroll@skia.org Roll Packages from 5db2635 to 15e7e89 (2 revisions) (flutter/flutter#175266)
2025-09-12 bruno.leroux@gmail.com Document Form.onChange precedence over DropdownButtonFormField.onChange (flutter/flutter#175249)
2025-09-12 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 1pTB3J5rn4YYugylf... to b1AYfAFOnvBMHSsYL... (flutter/flutter#175250)
2025-09-12 engine-flutter-autoroll@skia.org Roll Dart SDK from 7acebac57248 to a4075f2f670f (1 revision) (flutter/flutter#175245)
2025-09-11 engine-flutter-autoroll@skia.org Roll Dart SDK from f7d6a4732ab0 to 7acebac57248 (2 revisions) (flutter/flutter#175239)
2025-09-11 fluttergithubbot@gmail.com Marks Linux_pixel_7pro static_path_stroke_tessellation_perf__timeline_summary to be flaky (flutter/flutter#175174)
2025-09-11 devoncarew@google.com update deps to point to the new SOT repo for package:coverage (flutter/flutter#175234)
2025-09-11 sokolovskyi.konstantin@gmail.com [web] Fix image and color filters equality in SkWASM. (flutter/flutter#175230)
2025-09-11 engine-flutter-autoroll@skia.org Roll Packages from 03598e7 to 5db2635 (1 revision) (flutter/flutter#175232)
2025-09-11 32538273+ValentinVignal@users.noreply.github.com Migrate to widget state (flutter/flutter#174746)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
…_summary to be flaky (flutter#175174)

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_pixel_7pro
static_path_stroke_tessellation_perf__timeline_summary"
}
-->
Issue link: flutter#175173

Co-authored-by: Jim Graham <flar@google.com>
Jaineel-Mamtora pushed a commit to Jaineel-Mamtora/flutter_forked that referenced this pull request Sep 24, 2025
…_summary to be flaky (flutter#175174)

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_pixel_7pro
static_path_stroke_tessellation_perf__timeline_summary"
}
-->
Issue link: flutter#175173

Co-authored-by: Jim Graham <flar@google.com>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: flake Tests that sometimes, but not always, incorrectly pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants