Introduce a getter for `Project` to get `gradle-wrapper.properties` directly #175485

AbdeMohlbi · 2025-09-17T09:04:44Z

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I updated/added relevant documentation (doc comments with ///).
I followed the breaking change policy and added Data Driven Fixes where supported.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

reidbaker

This pr should add test but I wont block landing this improvement on one.

AbdeMohlbi · 2025-09-17T14:35:36Z

This pr should add test but I wont block landing this improvement on one.

Yeah the issue is that i'm not sure how to write tests for this getter or where to put it
(Project_test,gradle_test , gradle_errors_test )

AbdeMohlbi · 2025-09-17T14:36:13Z

This pr should add test but I wont block landing this improvement on one.

Is there an example that i could look at ?

reidbaker · 2025-09-17T15:07:05Z

This pr should add test but I wont block landing this improvement on one.

Is there an example that i could look at ?

I think since this is such a simple method modifying the usages of gradle.properties in packages/flutter_tools/test/general.shard/android/android_gradle_builder_test.dart would ensure this method is under test and make that test less fragile.

for example

flutter/packages/flutter_tools/test/general.shard/android/android_gradle_builder_test.dart

Line 96 in 29a0bc1

    
           fileSystem.directory('android').childFile('gradle.properties').createSync(recursive: true);

would look more like lines

flutter/packages/flutter_tools/test/general.shard/android/android_gradle_builder_test.dart

Lines 105 to 106 in 29a0bc1

    
           project.android.appManifestFile 
        
             ..createSync(recursive: true)

AbdeMohlbi · 2025-09-17T16:25:04Z

This pr should add test but I wont block landing this improvement on one.

Is there an example that i could look at ?

I think since this is such a simple method modifying the usages of gradle.properties in packages/flutter_tools/test/general.shard/android/android_gradle_builder_test.dart would ensure this method is under test and make that test less fragile.

for example

flutter/packages/flutter_tools/test/general.shard/android/android_gradle_builder_test.dart

Line 96 in 29a0bc1

fileSystem.directory('android').childFile('gradle.properties').createSync(recursive: true);

would look more like lines

flutter/packages/flutter_tools/test/general.shard/android/android_gradle_builder_test.dart

Lines 105 to 106 in 29a0bc1

project.android.appManifestFile

..createSync(recursive: true)

i think smth is wrong because this getter should return gradle-wrapper.properties not gradle.properties or i'm missing smth @reidbaker

reidbaker · 2025-09-17T16:26:51Z

Sorry you might be correct, I was multitasking.

Instead look for examples in the flutter_tools/tests directory where use make a properties file.

AbdeMohlbi · 2025-09-17T16:31:35Z

Sorry you might be correct I was multitasking.

Instead look for examples in the flutter_tools/tests directory where use make a properties file.

yeah this the issue all the instances of gradle-wrapper.properties do not use a Project

reidbaker · 2025-09-17T16:48:31Z

OK let us land this as is

AbdeMohlbi · 2025-09-17T16:56:43Z

OK let us land this as is

i did create a new group because i could not find any tests for the getters at all , so this may also serve as a starting point to add more tests

…perties` directly (flutter/flutter#175485)

…irectly (flutter#175485) follow up to [this comment](flutter#174760 (comment)) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…perties` directly (flutter/flutter#175485)

Roll Flutter from 4a042046a0f1 to b1a28bc065b0 (44 revisions) flutter/flutter@4a04204...b1a28bc 2025-09-25 48625061+muradhossin@users.noreply.github.com web_ui: avoid crash for showPerformanceOverlay; log 'not supported' once (flutter/flutter#173518) 2025-09-25 paulberry@google.com Ignore upcoming `experimental_member_use` warnings. (flutter/flutter#175969) 2025-09-25 engine-flutter-autoroll@skia.org Roll Skia from 753ce2221ce7 to 55436d87e414 (16 revisions) (flutter/flutter#176004) 2025-09-25 tirth@nevercode.io Add google_fonts to team-framework triage guidelines (flutter/flutter#175675) 2025-09-25 bruno.leroux@gmail.com Add tests for InputDecoration borders (M3 and theme normalization) (flutter/flutter#175838) 2025-09-24 737941+loic-sharma@users.noreply.github.com Update Flutter's templates to use dot shorthands (flutter/flutter#175891) 2025-09-24 matt.boetger@gmail.com In Gradle Flutter task, correctly replace '\ ' with ' '. (flutter/flutter#175815) 2025-09-24 47866232+chunhtai@users.noreply.github.com Cleans up navigator pop and remove logic (flutter/flutter#175612) 2025-09-24 rmolivares@renzo-olivares.dev Fix docs in `EditableText` (flutter/flutter#175787) 2025-09-24 47866232+chunhtai@users.noreply.github.com Fixes SemanticsFlags.isLink mis-translated in dart ui ffi (flutter/flutter#175812) 2025-09-24 1063596+reidbaker@users.noreply.github.com Update AGP/Java/Gradle comparison when using analyze --suggestions (flutter/flutter#175808) 2025-09-24 108678139+manu-sncf@users.noreply.github.com Fix SliverMainAxisGroup SliverEnsureSemantics support (flutter/flutter#175671) 2025-09-24 32538273+ValentinVignal@users.noreply.github.com Migrate to `WidgetStateColor` (flutter/flutter#175573) 2025-09-24 ahmedsameha1@gmail.com Make sure that a FlexibleSpaceBar doesn't crash in 0x0 environment (flutter/flutter#175228) 2025-09-24 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from BWj3yYC74ud58QhN0... to APSBP-sS-3FX69Ihf... (flutter/flutter#175944) 2025-09-24 ahmedsameha1@gmail.com Make sure that a MaterialApp doesn't crash in 0x0 environment (flutter/flutter#173090) 2025-09-24 36043466+koukibadr@users.noreply.github.com feat(cupertino): Add selectableDayPredicate parameter to CupertinoDatePicker for selectable day control #171332 (flutter/flutter#171334) 2025-09-24 mohellebiabdessalem@gmail.com Refactor `FlutterInjectorTest` to use lambdas/method reference (flutter/flutter#175777) 2025-09-24 mohellebiabdessalem@gmail.com Replace curly braces with lambdas in `KeyEventChannelTest` (flutter/flutter#175729) 2025-09-24 bkonyi@google.com [ Widget Preview ] Fix filter by file on Windows (flutter/flutter#175783) 2025-09-24 mohellebiabdessalem@gmail.com use lambda expressions /method reference to fix linter issue in `DartMessengerTest.java` (flutter/flutter#175733) 2025-09-24 engine-flutter-autoroll@skia.org Roll Packages from 3413b65 to 117bf63 (9 revisions) (flutter/flutter#175935) 2025-09-24 mohellebiabdessalem@gmail.com refactor code to use method reference and lambdas in `DartMessengerTest.java` (flutter/flutter#175731) 2025-09-24 mohellebiabdessalem@gmail.com Simplify/fix ordering of asserts in `TextInputPluginTest` (flutter/flutter#175784) 2025-09-24 mohellebiabdessalem@gmail.com Introduce a getter for `Project` to get `gradle-wrapper.properties` directly (flutter/flutter#175485) 2025-09-24 mohellebiabdessalem@gmail.com Change the arguments order in `assertEquals` to fix linter issues (flutter/flutter#175719) 2025-09-24 42980667+srivats22@users.noreply.github.com Broken link in NavigationRail documentation (flutter/flutter#175852) 2025-09-24 mdebbar@google.com Updates to flutter web triage links (flutter/flutter#175791) 2025-09-24 jason-simmons@users.noreply.github.com Do not present textures in FlutterMetalLayer if the drawable size changed and the texture's size does not match the new drawable size (flutter/flutter#175450) 2025-09-24 bkonyi@google.com Remove comment about trailing commas from templates (flutter/flutter#175864) 2025-09-24 engine-flutter-autoroll@skia.org Roll Skia from 1c1b19f2ffc3 to 753ce2221ce7 (4 revisions) (flutter/flutter#175909) 2025-09-24 engine-flutter-autoroll@skia.org Roll Skia from 3191a822cf10 to 1c1b19f2ffc3 (2 revisions) (flutter/flutter#175896) 2025-09-24 engine-flutter-autoroll@skia.org Roll Skia from cabeab8cb22c to 3191a822cf10 (14 revisions) (flutter/flutter#175894) 2025-09-24 engine-flutter-autoroll@skia.org Roll Dart SDK from 14b4ced3022a to 899c7340cc4c (4 revisions) (flutter/flutter#175893) 2025-09-24 paulberry@google.com Roll `package:analyzer` forward to `8.2.0`. (flutter/flutter#175849) 2025-09-24 ahmedsameha1@gmail.com Make sure that a VerticalDivider doesn't crash at 0x0 environment (flutter/flutter#174761) 2025-09-24 ahmedsameha1@gmail.com Make sure that Drawer & DrawerHeader don't crash in 0x0 environment (flutter/flutter#174772) 2025-09-24 rmolivares@renzo-olivares.dev Add an assertion for the relationship between `Visibility.maintainState` and `Visibility.maintainFocusability` (flutter/flutter#175552) 2025-09-24 34465683+rkishan516@users.noreply.github.com fix: remove final class modifier on MenuController (flutter/flutter#174490) 2025-09-24 34465683+rkishan516@users.noreply.github.com fix: cupertino sheet broken example with programatic pop (flutter/flutter#175709) 2025-09-24 mdebbar@google.com [web] Fix assertion thrown when hot restarting during animation (flutter/flutter#175856) 2025-09-24 krca0220@gmail.com Add non uniform TableBorder (flutter/flutter#175773) 2025-09-23 mohellebiabdessalem@gmail.com fix small typo in test docs (flutter/flutter#175776) 2025-09-23 mohellebiabdessalem@gmail.com Use `assertNull` to simplify code (flutter/flutter#175720) If this roll has caused a breakage, revert this CL and stop the roller ...

discovered while #175485 add tests for : - `appGradleFile` getter - `hostAppGradleFile` getter - `settingsGradleFile` getter - `appManifestFile` getter - `localPropertiesFile` getter ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

discovered while flutter#175485 add tests for : - `appGradleFile` getter - `hostAppGradleFile` getter - `settingsGradleFile` getter - `appManifestFile` getter - `localPropertiesFile` getter ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.  [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

…perties` directly (flutter/flutter#175485)

Update project.dart

8ee130f

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 17, 2025

Update gradle_errors.dart

818c9ba

github-actions bot added the team-android Owned by Android platform team label Sep 17, 2025

format

1ad76b9

AbdeMohlbi changed the title ~~WIP~~ Introduce a getter for Project to get gradle-wrapper.properties directly Sep 17, 2025

AbdeMohlbi marked this pull request as ready for review September 17, 2025 10:08

AbdeMohlbi requested a review from a team as a code owner September 17, 2025 10:08

reidbaker approved these changes Sep 17, 2025

View reviewed changes

reidbaker requested a review from a team September 17, 2025 15:07

AbdeMohlbi added 2 commits September 17, 2025 17:53

Update project_test.dart

e5c3e40

remove comment

f64a4d7

AbdeMohlbi requested a review from reidbaker September 17, 2025 16:54

reidbaker approved these changes Sep 17, 2025

View reviewed changes

AbdeMohlbi added 3 commits September 17, 2025 18:16

Update project_test.dart

951becb

Merge branch 'master' into patch-55

bb991dd

Merge branch 'master' into patch-55

01a7409

reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 24, 2025

auto-submit bot added this pull request to the merge queue Sep 24, 2025

Merged via the queue into flutter:master with commit 8dd9ff1 Sep 24, 2025
148 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 24, 2025

engine-flutter-autoroll mentioned this pull request Sep 24, 2025

Roll Flutter from 4a042046a0f1 to 439a80965a44 (21 revisions) flutter/packages#10071

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 24, 2025

8dd9ff1b5 Introduce a getter for Project to get `gradle-wrapper.pro…

87f166a

…perties` directly (flutter/flutter#175485)

engine-flutter-autoroll mentioned this pull request Sep 24, 2025

Roll Flutter from 4a042046a0f1 to 321ae32b3eee (23 revisions) flutter/packages#10072

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 24, 2025

8dd9ff1b5 Introduce a getter for Project to get `gradle-wrapper.pro…

0349f48

…perties` directly (flutter/flutter#175485)

engine-flutter-autoroll mentioned this pull request Sep 24, 2025

Roll Flutter from 4a042046a0f1 to 440e7c2978dd (24 revisions) flutter/packages#10073

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 24, 2025

8dd9ff1b5 Introduce a getter for Project to get `gradle-wrapper.pro…

4927338

…perties` directly (flutter/flutter#175485)

AbdeMohlbi mentioned this pull request Sep 25, 2025

Add tests for Project getters #175994

Merged

9 tasks

engine-flutter-autoroll mentioned this pull request Sep 25, 2025

Roll Flutter from 4a042046a0f1 to 57b7c46d0120 (43 revisions) flutter/packages#10076

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 25, 2025

8dd9ff1b5 Introduce a getter for Project to get `gradle-wrapper.pro…

88a4107

…perties` directly (flutter/flutter#175485)

engine-flutter-autoroll mentioned this pull request Sep 25, 2025

Roll Flutter from 4a042046a0f1 to b1a28bc065b0 (44 revisions) flutter/packages#10077

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 25, 2025

8dd9ff1b5 Introduce a getter for Project to get `gradle-wrapper.pro…

d97383e

…perties` directly (flutter/flutter#175485)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025

8dd9ff1b5 Introduce a getter for Project to get `gradle-wrapper.pro…

59379bf

…perties` directly (flutter/flutter#175485)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Introduce a getter for `Project` to get `gradle-wrapper.properties` directly #175485

Introduce a getter for `Project` to get `gradle-wrapper.properties` directly #175485

Uh oh!

AbdeMohlbi commented Sep 17, 2025 •

edited

Loading

Uh oh!

reidbaker left a comment

Uh oh!

AbdeMohlbi commented Sep 17, 2025

Uh oh!

AbdeMohlbi commented Sep 17, 2025 •

edited

Loading

Uh oh!

reidbaker commented Sep 17, 2025 •

edited

Loading

Uh oh!

AbdeMohlbi commented Sep 17, 2025

Uh oh!

reidbaker commented Sep 17, 2025 •

edited

Loading

Uh oh!

AbdeMohlbi commented Sep 17, 2025

Uh oh!

reidbaker commented Sep 17, 2025

Uh oh!

AbdeMohlbi commented Sep 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Introduce a getter for Project to get gradle-wrapper.properties directly #175485

Introduce a getter for Project to get gradle-wrapper.properties directly #175485

Uh oh!

Conversation

AbdeMohlbi commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

reidbaker left a comment

Choose a reason for hiding this comment

Uh oh!

AbdeMohlbi commented Sep 17, 2025

Uh oh!

AbdeMohlbi commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

reidbaker commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AbdeMohlbi commented Sep 17, 2025

Uh oh!

reidbaker commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AbdeMohlbi commented Sep 17, 2025

Uh oh!

reidbaker commented Sep 17, 2025

Uh oh!

AbdeMohlbi commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Introduce a getter for `Project` to get `gradle-wrapper.properties` directly #175485

Introduce a getter for `Project` to get `gradle-wrapper.properties` directly #175485

AbdeMohlbi commented Sep 17, 2025 •

edited

Loading

AbdeMohlbi commented Sep 17, 2025 •

edited

Loading

reidbaker commented Sep 17, 2025 •

edited

Loading

reidbaker commented Sep 17, 2025 •

edited

Loading

AbdeMohlbi commented Sep 17, 2025 •

edited

Loading