这是indexloc提供的服务，不要输入任何密码
Skip to content

Make sure that a DesktopTextSelectionToolbar doesn't crash in 0x0 env… #173928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2025
Merged

Make sure that a DesktopTextSelectionToolbar doesn't crash in 0x0 env… #173928

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions packages/flutter/test/material/desktop_text_selection_toolbar_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,20 @@ void main() {

expect(tester.getTopLeft(find.byType(DesktopTextSelectionToolbarButton)), anchor);
});

testWidgets('DesktopTextSelectionToolbar renders at zero area', (WidgetTester tester) async {
Copy link
Contributor

@dkwingsmt dkwingsmt Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
testWidgets('DesktopTextSelectionToolbar renders at zero area', (WidgetTester tester) async {
testWidgets('DesktopTextSelectionToolbar does not crash at zero area', (WidgetTester tester) async {

await tester.pumpWidget(
MaterialApp(
home: Center(
child: SizedBox.shrink(
child: DesktopTextSelectionToolbar(
anchor: const Offset(10, 10),
children: const <Widget>[Text('X')],
),
),
),
),
);
expect(tester.getSize(find.byType(DesktopTextSelectionToolbar)).isEmpty, isTrue);
Copy link
Contributor

@dkwingsmt dkwingsmt Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
expect(tester.getSize(find.byType(DesktopTextSelectionToolbar)).isEmpty, isTrue);
expect(tester.getSize(find.byType(DesktopTextSelectionToolbar)), Size.zero);

});
}