Make sure that a DateRangePickerDialog doesn't crash in 0x0 environments #173754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a regression test to ensure that DateRangePickerDialog does not crash when rendered in a zero-sized environment, addressing a reported issue. The test case is well-defined and covers the scenario. My review includes a couple of suggestions to improve the test's maintainability and clarity by adding a comment linking to the original issue and explicitly asserting that no exceptions are thrown, which are common practices in this test file.
| }); | ||
| }); | ||
|
|
||
| testWidgets('DateRangePickerDialog renders at zero area', (WidgetTester tester) async { |
Contributor
There was a problem hiding this comment.
For better maintainability and to provide context for this test, it's a good practice to add a comment linking to the issue it's fixing. This is a common pattern in this test file.
// Regression test for https://github.com/flutter/flutter/issues/6537
testWidgets('DateRangePickerDialog renders at zero area', (WidgetTester tester) async {
Comment on lines
1978
to
1982
| ); | ||
| }); |
Contributor
There was a problem hiding this comment.
To make the test's intent clearer and more robust, it's good practice to explicitly assert that no exception was thrown during widget rendering. This pattern is used in other tests in this file.
);
expect(tester.takeException(), isNull);
});
c8f6806 to
bfe9dd4
Compare
bfe9dd4 to
f87f9ae
Compare
dkwingsmt
reviewed
Sep 18, 2025
Contributor
dkwingsmt
left a comment
There was a problem hiding this comment.
Checklist:
- The test is in the correct file
- The test name goes “does not crash at zero area”
- The target widget is wrapped by
Center(or is fullscreen) - The target widget does not have an overlay, or the overlay is tested
- The target widget is expected to have a size of exactly
Size.zero
| ), | ||
| ), | ||
| ); | ||
| expect(tester.getSize(find.byType(DateRangePickerDialog)).isEmpty, isTrue); |
Contributor
There was a problem hiding this comment.
Suggested change
| expect(tester.getSize(find.byType(DateRangePickerDialog)).isEmpty, isTrue); | |
| expect(tester.getSize(find.byType(DateRangePickerDialog)), Size.zero); |
Contributor
|
autosubmit label was removed for flutter/flutter/173754, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR. |
532f0e7 to
804c9be
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 2, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 2, 2025
flutter/flutter@7811e89...65aca36 2025-10-02 engine-flutter-autoroll@skia.org Roll Skia from 257c1f94afaa to 05c1f5803415 (4 revisions) (flutter/flutter#176402) 2025-10-02 bkonyi@google.com [ Widget Preview ] Fix resolution for workspace "hosted" dependencies (flutter/flutter#176358) 2025-10-02 engine-flutter-autoroll@skia.org Roll Skia from b5d8ae8d3410 to 257c1f94afaa (6 revisions) (flutter/flutter#176389) 2025-10-02 flar@google.com Delete Skia-specific performance overlay implementation (flutter/flutter#176364) 2025-10-02 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 1Ai6VL4vb_GdGnWhg... to Vnoygds8HtDUvGLCK... (flutter/flutter#176381) 2025-10-01 bkonyi@google.com [ Widget Preview ] Persist "Filter by Selected File" toggle (flutter/flutter#176289) 2025-10-01 engine-flutter-autoroll@skia.org Roll Skia from c44a36470d07 to b5d8ae8d3410 (5 revisions) (flutter/flutter#176367) 2025-10-01 47866232+chunhtai@users.noreply.github.com Reapply "Update the AccessibilityPlugin::Announce method to account f… (flutter/flutter#176107) 2025-10-01 engine-flutter-autoroll@skia.org Roll Dart SDK from 8ffec1435cf3 to 4f90a06328cb (3 revisions) (flutter/flutter#176369) 2025-10-01 bkonyi@google.com [ Tool / l10n ] Fix issue where localization generator assumed current directory was the target project (flutter/flutter#175881) 2025-10-01 ahmedsameha1@gmail.com Make sure that a DateRangePickerDialog doesn't crash in 0x0 environments (flutter/flutter#173754) 2025-10-01 ahmedsameha1@gmail.com Make sure that a DrawerButton doesn't crash in 0x0 environment (flutter/flutter#172948) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
okorohelijah
pushed a commit
to okorohelijah/flutter
that referenced
this pull request
Oct 7, 2025
…nts (flutter#173754) This is my attempt to handle flutter#6537 for the DateRangePickerDialog UI control.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to handle #6537 for the DateRangePickerDialog UI control.