Make sure that a ChoiceChip doesn't crash in 0x0 environment #173322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a regression test to ensure that a ChoiceChip doesn't crash when rendered in a zero-sized environment, which is great for preventing future regressions. I've added one comment to make the test's intent more explicit by adding an assertion. It seems like the fix for the issue is missing from this PR. The title and description suggest a fix is included, but only the test file is changed. Could you please confirm if the fix will be in a separate PR or if it was missed here?
2679186 to
a2aaccf
Compare
victorsanni
approved these changes
Aug 8, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 14, 2025
flutter/flutter@34c2a3b...f4334d2 2025-08-14 engine-flutter-autoroll@skia.org Roll Dart SDK from 9b4691f35139 to 214a7f829913 (2 revisions) (flutter/flutter#173769) 2025-08-14 engine-flutter-autoroll@skia.org Roll Skia from b3e86773dae1 to dca5f05fee87 (4 revisions) (flutter/flutter#173763) 2025-08-14 engine-flutter-autoroll@skia.org Roll Dart SDK from 73153bdc1459 to 9b4691f35139 (3 revisions) (flutter/flutter#173755) 2025-08-14 engine-flutter-autoroll@skia.org Roll Skia from 5852eddfd404 to b3e86773dae1 (1 revision) (flutter/flutter#173750) 2025-08-14 azat24680@gmail.com Allow empty initial time when using text input mode in showTimePicker dialog (flutter/flutter#172847) 2025-08-13 engine-flutter-autoroll@skia.org Roll Skia from 525e2bf80559 to 5852eddfd404 (2 revisions) (flutter/flutter#173740) 2025-08-13 mdebbar@google.com [web] Popping a nameless route should preserve the correct route name (flutter/flutter#173652) 2025-08-13 ahmedsameha1@gmail.com Make sure that a ChoiceChip doesn't crash in 0x0 environment (flutter/flutter#173322) 2025-08-13 bkonyi@google.com [ Tool ] Fix missing import for widget_preview.dart (flutter/flutter#173731) 2025-08-13 engine-flutter-autoroll@skia.org Roll Skia from f7fdda3cd0e6 to 525e2bf80559 (7 revisions) (flutter/flutter#173727) 2025-08-13 matanlurey@users.noreply.github.com Do not include `:unittests` unless `enable_unittests` (flutter/flutter#173729) 2025-08-13 engine-flutter-autoroll@skia.org Roll Packages from 08a9b2c to 6cb9113 (1 revision) (flutter/flutter#173726) 2025-08-13 56157868+albinpk@users.noreply.github.com fix: selected date decorator renders outside PageView in `DatePickerDialog` dialog (flutter/flutter#171718) 2025-08-13 bkonyi@google.com [ Widget Preview ] Add `--machine` mode (flutter/flutter#173654) 2025-08-13 ahmedsameha1@gmail.com Make sure that a Chip doesn't crash in 0x0 environment (flutter/flutter#173245) 2025-08-13 returnymgstokh@icloud.com feat: Cupertino sheet implement upward stretch on full sheet (flutter/flutter#168547) 2025-08-13 131446187+TheLastFlame@users.noreply.github.com Fix visual overlap of transparent routes barrier when using FadeForwardsPageTransitionsBuilder (flutter/flutter#167032) 2025-08-13 32538273+ValentinVignal@users.noreply.github.com Fix `ChipThemeData` lerp for `BorderSide` (flutter/flutter#173160) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC louisehsu@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
SydneyBao
pushed a commit
to SydneyBao/flutter
that referenced
this pull request
Aug 14, 2025
…#173322) This is my attempt to handle flutter#6537 for the ChoiceChip UI control.
ksokolovskyi
pushed a commit
to ksokolovskyi/flutter
that referenced
this pull request
Aug 19, 2025
…#173322) This is my attempt to handle flutter#6537 for the ChoiceChip UI control.
WillBLogical
pushed a commit
to WillBLogical/packages
that referenced
this pull request
Aug 20, 2025
…r#9807) flutter/flutter@34c2a3b...f4334d2 2025-08-14 engine-flutter-autoroll@skia.org Roll Dart SDK from 9b4691f35139 to 214a7f829913 (2 revisions) (flutter/flutter#173769) 2025-08-14 engine-flutter-autoroll@skia.org Roll Skia from b3e86773dae1 to dca5f05fee87 (4 revisions) (flutter/flutter#173763) 2025-08-14 engine-flutter-autoroll@skia.org Roll Dart SDK from 73153bdc1459 to 9b4691f35139 (3 revisions) (flutter/flutter#173755) 2025-08-14 engine-flutter-autoroll@skia.org Roll Skia from 5852eddfd404 to b3e86773dae1 (1 revision) (flutter/flutter#173750) 2025-08-14 azat24680@gmail.com Allow empty initial time when using text input mode in showTimePicker dialog (flutter/flutter#172847) 2025-08-13 engine-flutter-autoroll@skia.org Roll Skia from 525e2bf80559 to 5852eddfd404 (2 revisions) (flutter/flutter#173740) 2025-08-13 mdebbar@google.com [web] Popping a nameless route should preserve the correct route name (flutter/flutter#173652) 2025-08-13 ahmedsameha1@gmail.com Make sure that a ChoiceChip doesn't crash in 0x0 environment (flutter/flutter#173322) 2025-08-13 bkonyi@google.com [ Tool ] Fix missing import for widget_preview.dart (flutter/flutter#173731) 2025-08-13 engine-flutter-autoroll@skia.org Roll Skia from f7fdda3cd0e6 to 525e2bf80559 (7 revisions) (flutter/flutter#173727) 2025-08-13 matanlurey@users.noreply.github.com Do not include `:unittests` unless `enable_unittests` (flutter/flutter#173729) 2025-08-13 engine-flutter-autoroll@skia.org Roll Packages from 08a9b2c to 6cb9113 (1 revision) (flutter/flutter#173726) 2025-08-13 56157868+albinpk@users.noreply.github.com fix: selected date decorator renders outside PageView in `DatePickerDialog` dialog (flutter/flutter#171718) 2025-08-13 bkonyi@google.com [ Widget Preview ] Add `--machine` mode (flutter/flutter#173654) 2025-08-13 ahmedsameha1@gmail.com Make sure that a Chip doesn't crash in 0x0 environment (flutter/flutter#173245) 2025-08-13 returnymgstokh@icloud.com feat: Cupertino sheet implement upward stretch on full sheet (flutter/flutter#168547) 2025-08-13 131446187+TheLastFlame@users.noreply.github.com Fix visual overlap of transparent routes barrier when using FadeForwardsPageTransitionsBuilder (flutter/flutter#167032) 2025-08-13 32538273+ValentinVignal@users.noreply.github.com Fix `ChipThemeData` lerp for `BorderSide` (flutter/flutter#173160) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC louisehsu@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
…#173322) This is my attempt to handle flutter#6537 for the ChoiceChip UI control.
korca0220
pushed a commit
to korca0220/flutter
that referenced
this pull request
Sep 22, 2025
…#173322) This is my attempt to handle flutter#6537 for the ChoiceChip UI control.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to handle #6537 for the ChoiceChip UI control.