-
Notifications
You must be signed in to change notification settings - Fork 29.5k
Remove properties from .ci.yaml no longer used by (docs) recipes
#173296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR refactors documentation properties in .ci.yaml into a structured docs map, improving readability. However, this is a breaking change for the CI system. It's critical to confirm that the corresponding CI recipes have been updated to parse this new format to prevent build failures. Additionally, a new stable value has been introduced for the post_process action without explanation; this requires clarification.
cd47eb6 to
8ff35a3
Compare
8ff35a3 to
bb386d4
Compare
bb386d4 to
0daa6c4
Compare
matanlurey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the PR title and description before submitting.
.ci.yaml no longer used by (docs) recipes
|
@ievdokdm Closer - I just would want the PR title to reflect what's happening. The git history will look like this: So saying Also, you need to explicitly write: (or I believe, |
|
I made the change for you. LGTM. |
…lutter#173296) Removed unused properties for `docs.py` recipes Fixes flutter#169108.
…lutter#173296) Removed unused properties for `docs.py` recipes Fixes flutter#169108.
…lutter#173296) Removed unused properties for `docs.py` recipes Fixes flutter#169108.
…lutter#173296) Removed unused properties for `docs.py` recipes Fixes flutter#169108.
Removed unused properties for
docs.pyrecipesFixes #169108.