这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@ievdokdm
Copy link
Contributor

@ievdokdm ievdokdm commented Aug 5, 2025

Removed unused properties for docs.py recipes

Fixes #169108.

@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Aug 5, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR refactors documentation properties in .ci.yaml into a structured docs map, improving readability. However, this is a breaking change for the CI system. It's critical to confirm that the corresponding CI recipes have been updated to parse this new format to prevent build failures. Additionally, a new stable value has been introduced for the post_process action without explanation; this requires clarification.

@ievdokdm ievdokdm force-pushed the 169108-ci-experiment branch from cd47eb6 to 8ff35a3 Compare August 5, 2025 18:27
@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. platform-web Web applications specifically team-android Owned by Android platform team team-ios Owned by iOS platform team labels Aug 5, 2025
@ievdokdm ievdokdm force-pushed the 169108-ci-experiment branch from 8ff35a3 to bb386d4 Compare August 5, 2025 18:30
@github-actions github-actions bot removed a: text input Entering text in a text field or keyboard related problems tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. f: material design flutter/packages/flutter/material repository. platform-web Web applications specifically team-android Owned by Android platform team team-ios Owned by iOS platform team labels Aug 5, 2025
@ievdokdm ievdokdm force-pushed the 169108-ci-experiment branch from bb386d4 to 0daa6c4 Compare August 5, 2025 19:37
@ievdokdm ievdokdm requested a review from matanlurey August 5, 2025 19:39
Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR title and description before submitting.

@ievdokdm ievdokdm changed the title 169108 ci.yaml docs.py properties upadate 169108 ci.yaml docs.py properties cleanup Aug 5, 2025
@matanlurey matanlurey changed the title 169108 ci.yaml docs.py properties cleanup Remove properties from .ci.yaml no longer used by (docs) recipes Aug 5, 2025
@matanlurey
Copy link
Contributor

@ievdokdm Closer - I just would want the PR title to reflect what's happening.

The git history will look like this:
https://github.com/flutter/flutter/commits/master/

So saying 169108 ci.yaml docs.py properties upadate is pretty cryptic.

Also, you need to explicitly write:

Fixes #1234

(or I believe, Closes ...) to trigger GitHub knowing to close the issue when merged, if that was your intent.

@matanlurey
Copy link
Contributor

I made the change for you. LGTM.

@ievdokdm ievdokdm marked this pull request as ready for review August 5, 2025 19:58
@ievdokdm ievdokdm added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 5, 2025
@ievdokdm ievdokdm added this pull request to the merge queue Aug 5, 2025
Merged via the queue into flutter:master with commit de33a3b Aug 5, 2025
153 checks passed
@ievdokdm ievdokdm deleted the 169108-ci-experiment branch August 5, 2025 20:58
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 5, 2025
danilozhang pushed a commit to danilozhang/flutter that referenced this pull request Aug 6, 2025
ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Aug 19, 2025
mboetger pushed a commit to mboetger/flutter that referenced this pull request Sep 18, 2025
korca0220 pushed a commit to korca0220/flutter that referenced this pull request Sep 22, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup and make explicit the flutter/docs recipe and related tools

2 participants