In "flutter create", use the project directory in the suggested "cd" command instead of the main source file path #173132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…command instead of the main source file path
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly changes the suggested cd command in flutter create to use the project directory path instead of the main source file path. The accompanying test change is also an improvement. I've suggested a small refinement to the test to make it more robust.
Comment on lines
4822
to
4823
| RegExp cdLine = RegExp(r'^ \$ cd .*flutter_project$', multiLine: true); | ||
| expect(cdLine.hasMatch(logger.statusText), isTrue); |
Contributor
There was a problem hiding this comment.
This is a good improvement to make the test more specific. To make it even more robust and less reliant on hardcoded strings, you could construct the expected path from the projectDir variable. This avoids hardcoding flutter_project and ensures the test correctly handles any changes to the test setup or relative path generation.1
final String expectedPath = globals.fs.path.relative(projectDir.path);
final RegExp cdLine = RegExp(r'^ \$ cd ' + RegExp.escape(expectedPath) + r'$', multiLine: true);
expect(cdLine.hasMatch(logger.statusText), isTrue, reason: 'statusText does not contain "cd $expectedPath"');
Style Guide References
Footnotes
matanlurey
approved these changes
Aug 1, 2025
Contributor
|
If this made it into 3.35 we should probably cherrypick it (to beta) after merging. |
Member
Author
|
This issue does not affect the 3.35 branch. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 5, 2025
…sted "cd" command instead of the main source file path (flutter/flutter#173132)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 5, 2025
…sted "cd" command instead of the main source file path (flutter/flutter#173132)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 5, 2025
…sted "cd" command instead of the main source file path (flutter/flutter#173132)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 5, 2025
…sted "cd" command instead of the main source file path (flutter/flutter#173132)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 5, 2025
…sted "cd" command instead of the main source file path (flutter/flutter#173132)
danilozhang
pushed a commit
to danilozhang/flutter
that referenced
this pull request
Aug 6, 2025
…command instead of the main source file path (flutter#173132)
ksokolovskyi
pushed a commit
to ksokolovskyi/flutter
that referenced
this pull request
Aug 19, 2025
…command instead of the main source file path (flutter#173132)
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
…command instead of the main source file path (flutter#173132)
korca0220
pushed a commit
to korca0220/flutter
that referenced
this pull request
Sep 22, 2025
…command instead of the main source file path (flutter#173132)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 12, 2025
…sted "cd" command instead of the main source file path (flutter/flutter#173132)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.