[ Tool ] Remove support for experimental --fast-start feature
#173576
Conversation
This feature never worked correctly and has been disabled by default for years. Fixes #49499
There was a problem hiding this comment.
Code Review
This pull request removes the experimental --fast-start feature, which has been disabled by default for a long time and was not working correctly. The changes touch multiple files across the tool to remove the flag, related logic, and tests.
While most of the removals are straightforward, I've found a critical issue in packages/flutter_tools/gradle/src/main/kotlin/tasks/BaseFlutterTaskHelper.kt where the logic change incorrectly forces all Android debug builds to use a splash screen entrypoint without the corresponding mechanism to load the actual application. This will likely break all Android debug builds. I've provided a suggestion to fix this. The rest of the changes look good.
reidbaker
left a comment
There was a problem hiding this comment.
Please add an entry to the blog post about this.
|
autosubmit label was removed for flutter/flutter/173576, because - The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
autosubmit label was removed for flutter/flutter/173576, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
Looks like this test is blocked by some failing google tests. Would you be able to take a look at this? @bkonyi |
Yep, it's on my TODO list :) |
|
autosubmit label was removed for flutter/flutter/173576, because - The status or check suite Linux gradle_java8_compile_test has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
autosubmit label was removed for flutter/flutter/173576, because - The status or check suite Windows tool_integration_tests_2_9 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
autosubmit label was removed for flutter/flutter/173576, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
…ter#173576) This feature never worked correctly and has been disabled by default for years. Fixes flutter#49499
…ter#173576) This feature never worked correctly and has been disabled by default for years. Fixes flutter#49499
This feature never worked correctly and has been disabled by default for years.
Fixes #49499