Trigger an engine build for the 3.38 beta release #176842
Conversation
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
There was a problem hiding this comment.
Code Review
This pull request introduces a temporary file, engine/TRIGGER.md, to initiate an engine build for the 3.38 beta release. The file is slated for deletion in a subsequent commit. My review includes one suggestion to add a final newline to the file, which is a standard convention for text files and improves compatibility with various development tools.
| @@ -0,0 +1,2 @@ | |||
| <!-- TODO(camsim99): Delete this file. --> | |||
| This file is purely to trigger an engine release build and will be deleted in a future commit pre-release. No newline at end of file | |||
There was a problem hiding this comment.
It's a good practice for text files to end with a single newline character. This prevents potential issues with some command-line tools (like cat and wc) and can avoid unexpected behavior in some diff viewers or when concatenating files.
| This file is purely to trigger an engine release build and will be deleted in a future commit pre-release. | |
| This file is purely to trigger an engine release build and will be deleted in a future commit pre-release. | |
2b8e65b
into
flutter:flutter-3.38-candidate.0
My PR updating engine.version (#177178) for the 3.38.0 beta release isn't passing the analyzer because the engine artifacts don't exist. This PR will trigger another engine build, and then I'll use its merge SHA in engine.version. And it conveniently deletes the file used for this same purpose in #176842.
The file added will be deleted. This is just to trigger an engine build.
Work around for #176838.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.