Add verbose logs to module_uiscene_test_ios #176306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds verbose logging to the pod install command in the module_uiscene_test_ios test, to help debug a CI failure. It also disables CocoaPods analytics to improve performance. My review suggests a small refinement to use exec instead of eval for better memory efficiency when handling verbose logs.
Comment on lines
214
to
224
| await eval( | ||
| 'pod', | ||
| <String>['install'], | ||
| environment: <String, String>{'LANG': 'en_US.UTF-8'}, | ||
| <String>['install', '--verbose'], | ||
| environment: <String, String>{ | ||
| // See https://github.com/flutter/flutter/issues/10873. | ||
| // CocoaPods analytics adds a lot of latency. | ||
| 'COCOAPODS_DISABLE_STATS': 'true', | ||
| 'LANG': 'en_US.UTF-8', | ||
| }, | ||
| workingDirectory: xcodeProjectDir.path, | ||
| printStdout: false, | ||
| printStderr: false, | ||
| ); |
Contributor
There was a problem hiding this comment.
Since the return value of eval is not being used, it's more efficient to use exec here. The eval function buffers the entire standard output into a string to be returned, which can be memory-intensive with verbose logging enabled. The exec function will print the output to the console by default without buffering the entire output in memory, which is more suitable for this use case.
Suggested change
| await eval( | |
| 'pod', | |
| <String>['install'], | |
| environment: <String, String>{'LANG': 'en_US.UTF-8'}, | |
| <String>['install', '--verbose'], | |
| environment: <String, String>{ | |
| // See https://github.com/flutter/flutter/issues/10873. | |
| // CocoaPods analytics adds a lot of latency. | |
| 'COCOAPODS_DISABLE_STATS': 'true', | |
| 'LANG': 'en_US.UTF-8', | |
| }, | |
| workingDirectory: xcodeProjectDir.path, | |
| printStdout: false, | |
| printStderr: false, | |
| ); | |
| await exec( | |
| 'pod', | |
| <String>['install', '--verbose'], | |
| environment: <String, String>{ | |
| // See https://github.com/flutter/flutter/issues/10873. | |
| // CocoaPods analytics adds a lot of latency. | |
| 'COCOAPODS_DISABLE_STATS': 'true', | |
| 'LANG': 'en_US.UTF-8', | |
| }, | |
| workingDirectory: xcodeProjectDir.path, | |
| ); |
jmagman
approved these changes
Sep 30, 2025
LouiseHsu
approved these changes
Sep 30, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 1, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 1, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 1, 2025
…10160) Manual roll requested by tarrinneal@google.com flutter/flutter@c9608e2...7811e89 2025-10-01 32538273+ValentinVignal@users.noreply.github.com Migrate to `WidgetStateTextStyle` (flutter/flutter#176330) 2025-10-01 32538273+ValentinVignal@users.noreply.github.com Migrate to `WidgetStateOutlinedBorder` (flutter/flutter#176270) 2025-10-01 matej.knopp@gmail.com [win32] Runloop should use high resolution timer and avoid deadlock (flutter/flutter#176023) 2025-10-01 engine-flutter-autoroll@skia.org Roll Packages from 287739d to 321a584 (3 revisions) (flutter/flutter#176357) 2025-10-01 15619084+vashworth@users.noreply.github.com Add SwiftUI support for UIScene migration (flutter/flutter#176230) 2025-10-01 engine-flutter-autoroll@skia.org Roll Skia from ecaff95f51aa to c44a36470d07 (4 revisions) (flutter/flutter#176336) 2025-10-01 dacoharkes@google.com [native assets] Enable build hooks and code assets on stable (flutter/flutter#176285) 2025-10-01 dacoharkes@google.com [native assets] Roll dependencies (flutter/flutter#176287) 2025-10-01 engine-flutter-autoroll@skia.org Roll Dart SDK from 527333cfe4cf to 8ffec1435cf3 (1 revision) (flutter/flutter#176334) 2025-10-01 engine-flutter-autoroll@skia.org Roll Skia from 6998b06397c5 to ecaff95f51aa (1 revision) (flutter/flutter#176333) 2025-10-01 Krzysztof.swietnicki@gmail.com Update description in _LastFinderMixin to properly describe finding last (flutter/flutter#174232) 2025-10-01 engine-flutter-autoroll@skia.org Roll Skia from b242cc09488d to 6998b06397c5 (2 revisions) (flutter/flutter#176331) 2025-10-01 engine-flutter-autoroll@skia.org Roll Dart SDK from af31d2637b6b to 527333cfe4cf (17 revisions) (flutter/flutter#176325) 2025-10-01 scheglov@google.com Stop using deprecated analyzer 7.x.y APIs. (flutter/flutter#176242) 2025-10-01 victorsanniay@gmail.com Fix docs referencing deprecated radio properties (flutter/flutter#176244) 2025-09-30 engine-flutter-autoroll@skia.org Roll Skia from bb3b6bd4be0d to b242cc09488d (22 revisions) (flutter/flutter#176320) 2025-09-30 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from rcOl0yxJb4znJ903Y... to 1Ai6VL4vb_GdGnWhg... (flutter/flutter#176315) 2025-09-30 47866232+chunhtai@users.noreply.github.com Adds dart ui API for setting application level locale (flutter/flutter#175100) 2025-09-30 mohellebiabdessalem@gmail.com replace `onPop` usage with `onPopWithResult` in `navigation_bar.2.dart ` (flutter/flutter#174841) 2025-09-30 bkonyi@google.com [ Widget Preview ] Forward Widget Inspector navigation events via DTD (flutter/flutter#176218) 2025-09-30 15619084+vashworth@users.noreply.github.com Add verbose logs to module_uiscene_test_ios (flutter/flutter#176306) 2025-09-30 zhongliu88889@gmail.com Web semantics: Fix email field selection/cursor by using type="text" + inputmode="email" (flutter/flutter#175876) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
okorohelijah
pushed a commit
to okorohelijah/flutter
that referenced
this pull request
Oct 7, 2025
Debugging why https://ci.chromium.org/ui/p/flutter/builders/staging/Mac%20module_uiscene_test_ios is failing. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugging why https://ci.chromium.org/ui/p/flutter/builders/staging/Mac%20module_uiscene_test_ios is failing.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.