Update CHANGELOG
#176654
Update CHANGELOG
#176654
Conversation
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
There was a problem hiding this comment.
Code Review
This pull request updates the CHANGELOG.md file to add release notes for the 3.35.6 hotfix. It includes two changes: an enhancement to the flutter analyze --suggestions command and a fix for a crash with the Vulkan Impeller backend. The formatting of an existing entry is also improved to be a list item and to use backticks for a command.
CHANGELOG.md
Outdated
|
|
||
| [flutter/175669](https://github.com/flutter/flutter/issues/175669) Flutter analyze --suggestions supports versions up to Java 25, Gradle 9 and AGP 9, Kotlin 2.2.20. | ||
| - [flutter/175669](https://github.com/flutter/flutter/issues/175669) `flutter analyze --suggestions` supports versions up to Java 25, Gradle 9 and AGP 9, Kotlin 2.2.20. | ||
| - [flutter/172624](https://github.com/flutter/flutter/issues/172624) When using the Vulkan Impeller backend, apps can crash due to a corrupted cache on some devices. |
There was a problem hiding this comment.
This change log does not say what happens. Ex did we fix the root cause or did we make it no longer crash. Also it links to an open not a close bug. @jason-simmons Can you help camille get a good changelog message here?
There was a problem hiding this comment.
I think more context would help this message, so @jason-simmons let me know. However, I would like to point out that I directly followed the best practices here:
.I think mentioning what we fixed could be useful, though, so maybe it's time for us to revisit these "best practices".
There was a problem hiding this comment.
How about:
Fixes an issue that could result in a corrupt pipeline cache when using the Impeller Vulkan back end.
There was a problem hiding this comment.
That's much clearer and succinct. Thanks!
Fixes an issue that could result in a corrupt pipeline cache when using the Impeller Vulkan back end.
|
Chatted with @jason-simmons offline and we decided to close the linked issue #172624 for clarity. |
9f455d2
into
flutter:flutter-3.35-candidate.0
Updates
CHANGELOGto include the two cherry picks in the 3.35.6 hotfix stable release:#176520
#176359
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.