Keyboard Animation Fix #176418

mboetger · 2025-10-02T16:55:11Z

Fixing Keyboard Animation Issue
Before:

Screen_recording_20251001_152525.mp4

After:

Screen_recording_20251002_095046.mp4

Fixes: #168768

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

reidbaker · 2025-10-02T18:04:33Z

It wasnt obvious to me where tests for this class lived. I think it is engine/src/flutter/shell/platform/android/test/io/flutter/plugin/editing/TextInputPluginTest.java

This reverts commit a52c1af.

gmackall

When trying to change any piece of this logic in the past I've experienced it breaking random individual modes of https://api.flutter.dev/flutter/services/SystemUiMode.html

Have you tested those modes as well? If not, can you try opting out of edge-to-edge as described here https://docs.flutter.dev/release/breaking-changes/default-systemuimode-edge-to-edge?_gl=1*q1wl35*_ga*MTM2MzE0NDc2My4xNzU4NzUzNDI0*_ga_04YGWK0175*czE3NTk1MTc5MTkkbzUkZzAkdDE3NTk1MTgwNDAkajYwJGwwJGgw#migration-guide, and ensure that those modes aren't regressed? Sorry to add a bunch more validation work but this has historically been extremely brittle.

gmackall · 2025-10-03T19:12:02Z

...flutter/shell/platform/android/io/flutter/plugin/editing/ImeSyncDeferringInsetsCallback.java

      int excludedInsets = 0;
      int systemUiFlags = view.getWindowSystemUiVisibility();
-      if ((systemUiFlags & View.SYSTEM_UI_FLAG_LAYOUT_HIDE_NAVIGATION) == 0
+      if (!((systemUiFlags & View.SYSTEM_UI_FLAG_LAYOUT_STABLE) != 0


nit: This conditional is getting too long for me to understand it, written inline. Are there any logical pieces you can break out of here into intermediate booleans with helpful names?

gmackall

Change LGTM though if those comments are addressed.

mboetger · 2025-10-03T20:17:26Z

When trying to change any piece of this logic in the past I've experienced it breaking random individual modes of https://api.flutter.dev/flutter/services/SystemUiMode.html

Have you tested those modes as well? If not, can you try opting out of edge-to-edge as described here https://docs.flutter.dev/release/breaking-changes/default-systemuimode-edge-to-edge?_gl=1*q1wl35*_ga*MTM2MzE0NDc2My4xNzU4NzUzNDI0*_ga_04YGWK0175*czE3NTk1MTc5MTkkbzUkZzAkdDE3NTk1MTgwNDAkajYwJGwwJGgw#migration-guide, and ensure that those modes aren't regressed? Sorry to add a bunch more validation work but this has historically been extremely brittle.

Yeah, I need to go back and test the code sample provided in #109623 pre-15 and post-15. Will do before submitting.

mboetger · 2025-10-06T16:42:15Z

@gmackall For API 36, Using the repro app for #109623:

Before

Screen_recording_20251006_093656.mp4

After

Screen_recording_20251006_093923.mp4

gmackall · 2025-10-06T17:51:04Z

@gmackall For API 36, Using the repro app for #109623:

Before

After

Nice, that lgtm

mboetger · 2025-10-06T18:57:11Z

https://api.flutter.dev/flutter/services/SystemUiMode.html

@gmackall For API 36, Using the repro app for #109623:
Before
After

Nice, that lgtm

Unfortunately, it looks to me like it breaks pre-15. It's harder for me to check, because I just have an emulator, but it definitely is creating too much space.
Screen_recording_20251006_110629.webm

That being said, it may just make sense to fork on the SDK level

if (Build.VERSION.SDK_INT < API_LEVELS.API_35) {

Reading this makes me think this is the correct call.

WDYT? @reidbaker @gmackall

Testing

reidbaker · 2025-10-06T19:00:19Z

That link takes me to https://developer.android.com/about/versions/15/behavior-changes-15 is there a subtitle that more specificly makes you think branching on 35+ behavior is the right thing to do?

reidbaker · 2025-10-06T19:02:10Z

That link takes me to https://developer.android.com/about/versions/15/behavior-changes-15 is there a subtitle that more specificly makes you think branching on 35+ behavior is the right thing to do?

Maybe https://developer.android.com/about/versions/15/behavior-changes-15#stable-configuration

mboetger · 2025-10-06T21:56:36Z

With the API fork, everything seems to be working correctly:

Android 12:
Screen_recording_20251006_135549.webm

Android 16:
https://github.com/user-attachments/assets/07fc7c84-e573-4cc7-bba6-e874dfa93270

That link takes me to https://developer.android.com/about/versions/15/behavior-changes-15 is there a subtitle that more specificly makes you think branching on 35+ behavior is the right thing to do?

Maybe https://developer.android.com/about/versions/15/behavior-changes-15#stable-configuration

Honestly, I cannot find anything definitive about the IME insets including the height of the navigation bar. It certainly seems like this is not the case post 15.

...e/src/flutter/shell/platform/android/test/io/flutter/plugin/editing/TextInputPluginTest.java

Roll Flutter from 908012d58baa to e11e2c11288b (39 revisions) flutter/flutter@908012d...e11e2c1 2025-10-08 vegorov@google.com Configure FfiNative resolver on dart:io (flutter/flutter#176621) 2025-10-08 fluttergithubbot@gmail.com Marks Linux_pixel_7pro service_extensions_test to be unflaky (flutter/flutter#176700) 2025-10-08 matt.boetger@gmail.com Keyboard Animation Fix (flutter/flutter#176418) 2025-10-08 34465683+rkishan516@users.noreply.github.com Feat: Add carousel view builder (flutter/flutter#172837) 2025-10-08 engine-flutter-autoroll@skia.org Roll Skia from d10a0d877ff4 to ea7cdbc6b986 (15 revisions) (flutter/flutter#176686) 2025-10-08 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from jJr3my9C6TwYWPygi... to xrIAL91ngrd-wNr9S... (flutter/flutter#176682) 2025-10-08 bruno.leroux@gmail.com Fix InputDecoration helper/error padding is not compliant (flutter/flutter#176353) 2025-10-08 sokolovskyi.konstantin@gmail.com Fix PopupMenu does not update when PopupMenuTheme in Theme changes. (flutter/flutter#175513) 2025-10-07 iinozemtsev@google.com Roll Dart SDK to 3.10.0-290.1.beta (flutter/flutter#176629) 2025-10-07 bkonyi@google.com [ Tool ] Output `app.dtd` and `app.devTools` in machine mode (flutter/flutter#176655) 2025-10-07 15619084+vashworth@users.noreply.github.com Rename UIScene integration test projects and fix Xcode compatibility (flutter/flutter#176635) 2025-10-07 21270878+elliette@users.noreply.github.com Selecting an implementation widget with the on-device inspector opens the code location for the nearest project widget (flutter/flutter#176530) 2025-10-07 32538273+ValentinVignal@users.noreply.github.com Migrate to `WidgetStateInputBorder` (flutter/flutter#176386) 2025-10-07 34871572+gmackall@users.noreply.github.com Make it clear that you need to install clangd in VSCode intellisense c++ config (flutter/flutter#176609) 2025-10-07 paulberry@google.com Bump the customer tests to pick up an update to Zulip's tests. (flutter/flutter#176463) 2025-10-07 engine-flutter-autoroll@skia.org Roll Packages from d3ef88b to 8ca6416 (2 revisions) (flutter/flutter#176633) 2025-10-07 15619084+vashworth@users.noreply.github.com Add fallback for 'scene:willConnectToSession:options' (flutter/flutter#176580) 2025-10-07 engine-flutter-autoroll@skia.org Roll Skia from d09786dfb854 to d10a0d877ff4 (11 revisions) (flutter/flutter#176616) 2025-10-07 bkonyi@google.com [ Widget Preview ] Rework UI and theming (flutter/flutter#176581) 2025-10-07 15619084+vashworth@users.noreply.github.com Handle FlutterEngine registration when embedded in Multi-Scene apps (flutter/flutter#176490) 2025-10-07 robert.ancell@canonical.com Fix code style in Linux embedder template (flutter/flutter#176256) 2025-10-07 15619084+vashworth@users.noreply.github.com Add tooling to migrate to UIScene (flutter/flutter#176427) 2025-10-06 danny@tuppeny.com Bump customer tests.version to 986c4326b4e4bb4e37bc963c2cc2aaa10b943859 (flutter/flutter#176594) 2025-10-06 43959652+TDuffinNTU@users.noreply.github.com Fix typo in pages.dart (flutter/flutter#176438) 2025-10-06 34465683+rkishan516@users.noreply.github.com Fix: Update anchorRect for overlayBuilder when anchor moves (flutter/flutter#169814) 2025-10-06 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Zm6K_3gP3VCaMy9rH... to jJr3my9C6TwYWPygi... (flutter/flutter#176591) 2025-10-06 eternalkaif@gmail.com Fix deprecated configureStatusBarForFullscreenFlutterExperience for Android 15+ (flutter/flutter#175501) 2025-10-06 30870216+gaaclarke@users.noreply.github.com updates docs for flutter engine footprint (flutter/flutter#176217) 2025-10-06 bkonyi@google.com [ Widget Preview ] Fix `WidgetInspectorService` override (flutter/flutter#176550) 2025-10-06 bruno.leroux@gmail.com Fix NavigatorBar lacks visual feedback (flutter/flutter#175182) 2025-10-06 engine-flutter-autoroll@skia.org Roll Packages from e401aeb to d3ef88b (4 revisions) (flutter/flutter#176582) 2025-10-06 engine-flutter-autoroll@skia.org Roll Dart SDK from 898380a41c90 to 6b0193498f09 (2 revisions) (flutter/flutter#176576) 2025-10-06 engine-flutter-autoroll@skia.org Roll Skia from bc7cf194f4ee to d09786dfb854 (1 revision) (flutter/flutter#176577) 2025-10-06 jason-simmons@users.noreply.github.com Roll vulkan-deps to a9e2ca3b (flutter/flutter#176322) 2025-10-06 15619084+vashworth@users.noreply.github.com Add an AppDelegate callback for implicit FlutterEngines (flutter/flutter#176240) 2025-10-06 engine-flutter-autoroll@skia.org Roll Skia from 45191c22b15c to bc7cf194f4ee (2 revisions) (flutter/flutter#176572) 2025-10-06 bkonyi@google.com [ Widget Preview ] Fix type error when retrieving flags from persistent preferences (flutter/flutter#176546) 2025-10-06 engine-flutter-autoroll@skia.org Roll Skia from 1fd0ca1f2120 to 45191c22b15c (3 revisions) (flutter/flutter#176556) 2025-10-05 engine-flutter-autoroll@skia.org Roll Dart SDK from 016a8c0045fd to 898380a41c90 (1 revision) (flutter/flutter#176549) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC muhatashim@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. ...

kale-xie · 2025-10-25T12:02:24Z

Hello, I’d like to ask whether updating Flutter to the latest version would resolve the issue of the keyboard causing the input field to jitter. I found that after updating to Flutter 3.35.7, the problem still persists.

reidbaker · 2025-10-27T14:32:44Z

To determine what versions of Flutter contain the fix, please see where’s my commit. If the commit has no release tag, it is currently only available in the master channel.

navigation bar problems

9d3f1ce

github-actions bot added platform-android Android applications specifically engine flutter/engine related. See also e: labels. team-android Owned by Android platform team labels Oct 2, 2025

correct systemUiFlags check

bf698ee

mboetger force-pushed the keyboard-168768 branch from 8daa119 to bf698ee Compare October 2, 2025 17:39

mboetger added 3 commits October 2, 2025 14:29

clean up with new APIs

a52c1af

Revert "clean up with new APIs"

5aeb18f

This reverts commit a52c1af.

added unit test

6541a58

mboetger marked this pull request as ready for review October 3, 2025 17:36

mboetger requested a review from a team as a code owner October 3, 2025 17:36

mboetger requested review from ash2moon and gmackall October 3, 2025 17:37

Merge branch 'master' into keyboard-168768

2b86076

gmackall reviewed Oct 3, 2025

View reviewed changes

gmackall approved these changes Oct 3, 2025

View reviewed changes

reidbaker approved these changes Oct 6, 2025

View reviewed changes

fork on api level instead

1c38ad4

mboetger requested review from gmackall and reidbaker October 6, 2025 22:39

reidbaker reviewed Oct 7, 2025

View reviewed changes

...e/src/flutter/shell/platform/android/test/io/flutter/plugin/editing/TextInputPluginTest.java Outdated Show resolved Hide resolved

reidbaker approved these changes Oct 7, 2025

View reviewed changes

mboetger and others added 2 commits October 7, 2025 10:24

change to minSdk

8dbce5c

Merge branch 'master' into keyboard-168768

620dbdc

mboetger added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 8, 2025

auto-submit bot added this pull request to the merge queue Oct 8, 2025

Merged via the queue into flutter:master with commit 3379c7f Oct 8, 2025
186 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 8, 2025

engine-flutter-autoroll mentioned this pull request Oct 8, 2025

Roll Flutter from 908012d58baa to 3379c7f0654b (37 revisions) flutter/packages#10190

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 8, 2025

3379c7f06 Keyboard Animation Fix (flutter/flutter#176418)

dd51c32

engine-flutter-autoroll mentioned this pull request Oct 8, 2025

Roll Flutter from 908012d58baa to 44c77df80a87 (38 revisions) flutter/packages#10191

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 8, 2025

3379c7f06 Keyboard Animation Fix (flutter/flutter#176418)

aed8113

engine-flutter-autoroll mentioned this pull request Oct 8, 2025

Roll Flutter from 908012d58baa to e11e2c11288b (39 revisions) flutter/packages#10192

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 8, 2025

3379c7f06 Keyboard Animation Fix (flutter/flutter#176418)

0b77a56

engine-flutter-autoroll mentioned this pull request Oct 8, 2025

Roll Flutter from 908012d58baa to c56e52be0710 (40 revisions) flutter/packages#10194

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 8, 2025

3379c7f06 Keyboard Animation Fix (flutter/flutter#176418)

701dc49

Keyboard Animation Fix #176418

Keyboard Animation Fix #176418

Uh oh!

Conversation

mboetger commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

reidbaker commented Oct 2, 2025

Uh oh!

gmackall left a comment

Choose a reason for hiding this comment

Uh oh!

gmackall Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gmackall left a comment

Choose a reason for hiding this comment

Uh oh!

mboetger commented Oct 3, 2025

Uh oh!

mboetger commented Oct 6, 2025

Uh oh!

gmackall commented Oct 6, 2025

Uh oh!

mboetger commented Oct 6, 2025

Uh oh!

reidbaker commented Oct 6, 2025

Uh oh!

reidbaker commented Oct 6, 2025

Uh oh!

mboetger commented Oct 6, 2025

Uh oh!

Uh oh!

Uh oh!

kale-xie commented Oct 25, 2025

Uh oh!

reidbaker commented Oct 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mboetger commented Oct 2, 2025 •

edited

Loading

gmackall Oct 3, 2025 •

edited

Loading