[a11y] : set isFocused will update isFocusable to true #170935

hannah-hyj · 2025-06-20T20:33:48Z

the isFocused and isFocusable flags should be more consistent,

this is also to prepare for #170696 ,

So all EditableText and TextField widgets will have isFocusable flag set to true now. (because they set isFocused).

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

packages/flutter/lib/src/semantics/semantics.dart

chunhtai

we also need to add a migration guide

packages/flutter/lib/src/semantics/semantics.dart

chunhtai · 2025-06-26T21:50:31Z

packages/flutter/lib/src/semantics/semantics.dart

-    _flags = _flags.copyWith(isFocused: value);
+  bool? get isFocused => _flags.isFocusable ? _flags.isFocused : null;
+  set isFocused(bool? value) {
+    if (value != null) {


if this is null, should this reset isFocusable? I looked at other property looks like they just pass the null to the flags, not sure if those make sense neither

I updated this to reset isFocusable to false if this is null, i think it makes more sense to me.

chunhtai · 2025-06-26T21:52:26Z

packages/flutter/lib/src/rendering/custom_paint.dart

@@ -955,7 +955,7 @@ class RenderCustomPaint extends RenderProxyBox {
      config.isFocusable = properties.focusable!;


we should attempt to migrate this, the focusable in SemanticsProperty should be deprecated as well

hannah-hyj · 2025-06-27T20:44:24Z

PR to add breaking changes doc flutter/website#12159

chunhtai · 2025-06-30T20:41:30Z

packages/flutter/lib/src/rendering/custom_paint.dart

-    }
-    if (properties.focused != null) {
-      config.isFocused = properties.focused!;
+    if (properties.focusable != null ||properties.focused != null) {


not formatted correctly

is this for backward compatibility? why do we need to check for focusable?

This was for backward compatibility but yeah this should be updated

previously, properties.focused== null means the properties don't have a meaningful value for focused , now it explicitly means this semantics node is not focusable. So the config.focused should be updated even if properties.focused is null. but if we always update config.focused , the _hasBeenAnnotated in semanticsNode might be messed up and the tree structure will change.

discussed offline, the tree structure changes are intended, for example the dropdown menu will lose a semantic node but the node contains no information.

packages/flutter/lib/src/rendering/proxy_box.dart

chunhtai · 2025-06-30T20:44:49Z

packages/flutter/lib/src/widgets/focus_scope.dart

@@ -726,7 +726,7 @@ class _FocusState extends State<Focus> {
                ? focusNode.requestFocus
                : null,
        focusable: _couldRequestFocus,


should remove any invocation to the deprecated property

looks like Semantics(focusable) is not deprecated. is there a reason we want to keep it around?

Yeah i should remove this, my mistake

chunhtai

LGTM

chunhtai · 2025-07-02T16:43:57Z

packages/flutter/lib/src/semantics/semantics.dart

+  @Deprecated(
+    'Setting isFocused automatically set this to true. '
+    'This feature was deprecated after v3.34.0-0.0.pre.',
+  )
  set isFocusable(bool value) {
    _flags = _flags.copyWith(isFocusable: value);
    _hasBeenAnnotated = true;
  }

  /// Whether the owning [RenderObject] currently holds the input focus.


the doc around isFocused should mention null if this is not focusable

here and elsewhere

chunhtai · 2025-07-02T16:46:18Z

packages/flutter/test/material/dropdown_menu_test.dart

@@ -3815,11 +3815,12 @@ void main() {
    await tester.pumpWidget(buildDropdownMenu(requestFocusOnTap: true));

    expect(
-      tester.getSemantics(find.byType(TextField)),


why this change?

The semantics tree structure didn't change after my PR. Only the isFocusable flag value is changed. however, tester.getSemantics(find.byType(TextField)) will find the node 3 : scopeRoute. tester.getSemantics(find.text('Test')) will find the node 5

hannah-hyj · 2025-07-11T22:48:52Z

This PR is failing dozens of google 3 tests , some because textfield now have isFocusable flags, some because of other reasons, i'm still fixing google 3 tests.

isfocusable changes revert inkwell changes isfocusable changes Update ink_well.dart Update semantics.dart lint Update shortcuts_test.dart fix tests test resolve comments fix tests Update semantics.dart fix tests resolve comments Update semantics.dart Update packages/flutter/lib/src/semantics/semantics.dart mark Deprecated Update semantics_test.dart update more tests fix tests updates lint Update semantics.dart Update semantics.dart Update semantics.dart Co-Authored-By: chunhtai <47866232+chunhtai@users.noreply.github.com>

This comment was marked as outdated.

Sign in to view

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: focus Focus traversal, gaining or losing focus labels Jun 20, 2025

hannah-hyj changed the title ~~[draft] : set isFocused will update isFocusable to true~~ [a11y] : set isFocused will update isFocusable to true Jun 25, 2025

github-actions bot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. f: cupertino flutter/packages/flutter/cupertino repository labels Jun 25, 2025

hannah-hyj requested a review from chunhtai June 25, 2025 06:24

github-actions bot removed the a: tests "flutter test", flutter_test, or one of our tests label Jun 25, 2025

hannah-hyj force-pushed the isfocusable-and-isfocused branch from 376de89 to 5408de2 Compare June 25, 2025 18:04

chunhtai reviewed Jun 26, 2025

View reviewed changes

packages/flutter/lib/src/semantics/semantics.dart Show resolved Hide resolved

chunhtai reviewed Jun 26, 2025

View reviewed changes

packages/flutter/lib/src/semantics/semantics.dart Outdated Show resolved Hide resolved

packages/flutter/lib/src/semantics/semantics.dart Outdated Show resolved Hide resolved

hannah-hyj force-pushed the isfocusable-and-isfocused branch from ed7ed86 to e823d05 Compare June 26, 2025 20:13

hannah-hyj requested a review from chunhtai June 26, 2025 20:25

chunhtai reviewed Jun 26, 2025

View reviewed changes

hannah-hyj requested a review from chunhtai June 27, 2025 20:13

chunhtai reviewed Jun 30, 2025

View reviewed changes

hannah-hyj requested a review from chunhtai July 2, 2025 02:23

chunhtai approved these changes Jul 2, 2025

View reviewed changes

hannah-hyj force-pushed the isfocusable-and-isfocused branch 2 times, most recently from 7a2c556 to 46f29bb Compare July 7, 2025 21:48

Renzo-Olivares mentioned this pull request Jul 10, 2025

[a11y] Add isFocusable to EditableText #170275

Closed

9 tasks

hannah-hyj force-pushed the isfocusable-and-isfocused branch from 46f29bb to 790c6c1 Compare July 11, 2025 21:00

hannah-hyj force-pushed the isfocusable-and-isfocused branch from e63ff63 to 9341156 Compare July 21, 2025 18:39

		@@ -955,7 +955,7 @@ class RenderCustomPaint extends RenderProxyBox {
		config.isFocusable = properties.focusable!;

[a11y] : set isFocused will update isFocusable to true #170935

Are you sure you want to change the base?

[a11y] : set isFocused will update isFocusable to true #170935

Conversation

hannah-hyj commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hannah-hyj commented Jun 27, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hannah-hyj Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hannah-hyj Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hannah-hyj Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hannah-hyj commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

hannah-hyj commented Jun 20, 2025 •

edited

Loading

hannah-hyj Jun 30, 2025 •

edited

Loading

hannah-hyj Jul 2, 2025 •

edited

Loading

hannah-hyj Jul 2, 2025 •

edited

Loading

hannah-hyj commented Jul 11, 2025 •

edited

Loading