Deprecate: Mark AppBarTheme & AppBarThemeData color parameter as deprecated in favor of backgroundColor #170624
Conversation
ab3969c to
44fb604
Compare
There was a problem hiding this comment.
Thank you for your contribution! Since AppbarThemeData also has this property now, maybe we can deprecate it as well:)
We might also want to add tests in /Users/quncheng/Desktop/flutter/packages/flutter/test_fixes/material/app_bar_theme.dart and /Users/quncheng/Desktop/flutter/packages/flutter/test_fixes/material/app_bar_theme.dart.expect to make sure the dart fix works.
44fb604 to
b3514de
Compare
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
Thanks for review @QuncCccccc, I have added deprecation for AppBarThemeData and also added tests as per your review. |
|
Since this is depreciation, we should have a migration guide even if the migration is to run dart fix. follow this https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#handling-breaking-changes template https://github.com/flutter/website/blob/main/src/content/release/breaking-changes/template.md |
@chunhtai Just have a question, if we are not actively removing the deprecated APIs, just marking them as deprecated, do we still need the migration guide? |
yes, marking deprecation should be accompanied with a migration guide. |
…r of backgroundColor
9e16e2c to
a9e28b8
Compare
|
@chunhtai I have created migration guide in website PR. |
…er as deprecated in favor of backgroundColor (flutter/flutter#170624)
…er as deprecated in favor of backgroundColor (flutter/flutter#170624)
…er as deprecated in favor of backgroundColor (flutter/flutter#170624)
…er as deprecated in favor of backgroundColor (flutter/flutter#170624)
…er as deprecated in favor of backgroundColor (flutter/flutter#170624)
…er as deprecated in favor of backgroundColor (flutter/flutter#170624)
…er as deprecated in favor of backgroundColor (flutter/flutter#170624)
…er as deprecated in favor of backgroundColor (flutter/flutter#170624)
…er as deprecated in favor of backgroundColor (flutter/flutter#170624)
…er as deprecated in favor of backgroundColor (flutter/flutter#170624)
…er as deprecated in favor of backgroundColor (flutter/flutter#170624)
…er as deprecated in favor of backgroundColor (flutter/flutter#170624)
…er as deprecated in favor of backgroundColor (flutter/flutter#170624)
…er as deprecated in favor of backgroundColor (flutter/flutter#170624)
…ecated in favor of backgroundColor (flutter#170624) Deprecate: Mark AppBarTheme color parameter as deprecated in favor of backgroundColor fixes: flutter#169918 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. --------- Co-authored-by: Qun Cheng <36861262+QuncCccccc@users.noreply.github.com>
Deprecate: Mark AppBarTheme color parameter as deprecated in favor of backgroundColor
fixes: #169918
Pre-launch Checklist
///).