[a11y] add RangeSlider to a11y test app as additional use-case #172922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a RangeSlider use case to the accessibility test application and refactors the use case system to categorize them as core or additional. A switch is added to the UI to toggle the visibility of additional use cases. The changes are well-structured and include necessary test updates. I have included a suggestion for improvement related to code readability.
| class MainWidgetState extends State<MainWidget> { | ||
| RangeValues _currentRangeValues = const RangeValues(20, 60); | ||
|
|
||
| String pageTitle = getUseCaseName(RangeSliderUseCase()); |
Contributor
There was a problem hiding this comment.
The pageTitle variable is initialized using getUseCaseName, which retrieves the name of the RangeSliderUseCase. Consider making this a final variable within the build method to optimize for readability and avoid unnecessary re-computation on each build.1
@override
Widget build(BuildContext context) {
final String pageTitle = getUseCaseName(RangeSliderUseCase());
Style Guide References
Footnotes
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 30, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jul 30, 2025
flutter/flutter@46b097a...c3279ca 2025-07-30 engine-flutter-autoroll@skia.org Roll Skia from 00765f238077 to da5a6704f8a3 (1 revision) (flutter/flutter#172966) 2025-07-30 engine-flutter-autoroll@skia.org Roll Skia from 62476cd444d2 to 00765f238077 (3 revisions) (flutter/flutter#172955) 2025-07-30 engine-flutter-autoroll@skia.org Roll Skia from 34693354289f to 62476cd444d2 (1 revision) (flutter/flutter#172950) 2025-07-30 engine-flutter-autoroll@skia.org Roll Skia from f72bd01a49b1 to 34693354289f (1 revision) (flutter/flutter#172946) 2025-07-30 yjbanov@google.com [a11y] add RangeSlider to a11y test app as additional use-case (flutter/flutter#172922) 2025-07-30 engine-flutter-autoroll@skia.org Roll Skia from a42898e5d622 to f72bd01a49b1 (21 revisions) (flutter/flutter#172944) 2025-07-29 bruno.leroux@gmail.com Fix SegmentedButton border doesn't reflect states (flutter/flutter#172754) 2025-07-29 robert.ancell@canonical.com Fix documentation for FlutterEngineRunTask (flutter/flutter#172889) 2025-07-29 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from tK_PAaLeo0pUxi8hv... to bQVQlLssTxxLjoDU0... (flutter/flutter#172925) 2025-07-29 31685655+SalehTZ@users.noreply.github.com fix(scrollbar): Update padding type to EdgeInsetsGeometry (flutter/flutter#172056) 2025-07-29 34871572+gmackall@users.noreply.github.com Refactor Android platform view code in advance of enabling HCPP on existing PV widgets (behind a flag) (flutter/flutter#170553) 2025-07-29 engine-flutter-autoroll@skia.org Roll Packages from 6b2e34e to ed235d1 (4 revisions) (flutter/flutter#172905) 2025-07-29 stuartmorgan@google.com Add package PR triage note (flutter/flutter#172898) 2025-07-29 30870216+gaaclarke@users.noreply.github.com Roll Skia from 409e1c7ba09b to a42898e5d622 (29 revisions) (flutter/flutter#172906) 2025-07-29 30870216+gaaclarke@users.noreply.github.com Made `android_gradle_print_build_variants_test.dart` more robust (flutter/flutter#172910) 2025-07-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland licenses cpp switch (#172671)" (flutter/flutter#172912) 2025-07-29 magder@google.com Fix Gemini Code Assist for GitHub config yaml (flutter/flutter#172887) 2025-07-29 fluttergithubbot@gmail.com Marks Linux_android_emu_unstable android_defines_test to be unflaky (flutter/flutter#171856) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC muhatashim@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth
pushed a commit
to vashworth/packages
that referenced
this pull request
Jul 30, 2025
…r#9699) flutter/flutter@46b097a...c3279ca 2025-07-30 engine-flutter-autoroll@skia.org Roll Skia from 00765f238077 to da5a6704f8a3 (1 revision) (flutter/flutter#172966) 2025-07-30 engine-flutter-autoroll@skia.org Roll Skia from 62476cd444d2 to 00765f238077 (3 revisions) (flutter/flutter#172955) 2025-07-30 engine-flutter-autoroll@skia.org Roll Skia from 34693354289f to 62476cd444d2 (1 revision) (flutter/flutter#172950) 2025-07-30 engine-flutter-autoroll@skia.org Roll Skia from f72bd01a49b1 to 34693354289f (1 revision) (flutter/flutter#172946) 2025-07-30 yjbanov@google.com [a11y] add RangeSlider to a11y test app as additional use-case (flutter/flutter#172922) 2025-07-30 engine-flutter-autoroll@skia.org Roll Skia from a42898e5d622 to f72bd01a49b1 (21 revisions) (flutter/flutter#172944) 2025-07-29 bruno.leroux@gmail.com Fix SegmentedButton border doesn't reflect states (flutter/flutter#172754) 2025-07-29 robert.ancell@canonical.com Fix documentation for FlutterEngineRunTask (flutter/flutter#172889) 2025-07-29 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from tK_PAaLeo0pUxi8hv... to bQVQlLssTxxLjoDU0... (flutter/flutter#172925) 2025-07-29 31685655+SalehTZ@users.noreply.github.com fix(scrollbar): Update padding type to EdgeInsetsGeometry (flutter/flutter#172056) 2025-07-29 34871572+gmackall@users.noreply.github.com Refactor Android platform view code in advance of enabling HCPP on existing PV widgets (behind a flag) (flutter/flutter#170553) 2025-07-29 engine-flutter-autoroll@skia.org Roll Packages from 6b2e34e to ed235d1 (4 revisions) (flutter/flutter#172905) 2025-07-29 stuartmorgan@google.com Add package PR triage note (flutter/flutter#172898) 2025-07-29 30870216+gaaclarke@users.noreply.github.com Roll Skia from 409e1c7ba09b to a42898e5d622 (29 revisions) (flutter/flutter#172906) 2025-07-29 30870216+gaaclarke@users.noreply.github.com Made `android_gradle_print_build_variants_test.dart` more robust (flutter/flutter#172910) 2025-07-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland licenses cpp switch (#172671)" (flutter/flutter#172912) 2025-07-29 magder@google.com Fix Gemini Code Assist for GitHub config yaml (flutter/flutter#172887) 2025-07-29 fluttergithubbot@gmail.com Marks Linux_android_emu_unstable android_defines_test to be unflaky (flutter/flutter#171856) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC muhatashim@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi
pushed a commit
to ksokolovskyi/flutter
that referenced
this pull request
Aug 19, 2025
…er#172922) Add `RangeSlider` as an additional use-case to the a11y_assessments app. As part of that this PR adds a `Switch` to the app bar of the app to reveal the additional use-cases. Each use-case is annotated to be either a `core` or `additional` using a new `enum`, which is also introduced in this PR.
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
…er#172922) Add `RangeSlider` as an additional use-case to the a11y_assessments app. As part of that this PR adds a `Switch` to the app bar of the app to reveal the additional use-cases. Each use-case is annotated to be either a `core` or `additional` using a new `enum`, which is also introduced in this PR.
korca0220
pushed a commit
to korca0220/flutter
that referenced
this pull request
Sep 22, 2025
…er#172922) Add `RangeSlider` as an additional use-case to the a11y_assessments app. As part of that this PR adds a `Switch` to the app bar of the app to reveal the additional use-cases. Each use-case is annotated to be either a `core` or `additional` using a new `enum`, which is also introduced in this PR.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
RangeSlideras an additional use-case to the a11y_assessments app. As part of that this PR adds aSwitchto the app bar of the app to reveal the additional use-cases. Each use-case is annotated to be either acoreoradditionalusing a newenum, which is also introduced in this PR.