Rename AppRunLogger, stop writing status messages that break JSON
#172591
+26
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chingjun
approved these changes
Jul 22, 2025
There was a problem hiding this comment.
LGTM other than the name MachineFlagLogger. I feel that MachineLogger or MachineOutputLogger sound more appropriate.
In most places, the variable that stores whether machine mode is turned on is called machine. (Random example)
The function in FlutterCommand that adds the flag is called addMachineOutputFlag
But the word machineFlag is exclusively used to refer to the --machine flag itself (mostly in flutter_command_runner.dart], and never used to refer to whether it is enabled, outside of that file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #118907.
It looks like some of the work around splitting had already happened (
DaemonLogger), so this ... seems right?