[Flutter GPU] Fix Android/GLES crashers. #172588
Open
+156
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -88,12 +88,12 @@ struct TexImage2DData { | |||
| type = GL_UNSIGNED_BYTE; | |||
| break; | |||
| case PixelFormat::kR32G32B32A32Float: | |||
| internal_format = GL_RGBA; | |||
| internal_format = GL_RGBA32F; | |||
There was a problem hiding this comment.
Does some form of capability checking already exist for these?
Fixing the enum values here sgtm though.
| @@ -75,7 +75,9 @@ class TextureGLES final : public Texture, | |||
| std::shared_ptr<ReactorGLES> reactor, | |||
| TextureDescriptor desc); | |||
|
|
|||
| TextureGLES(std::shared_ptr<ReactorGLES> reactor, TextureDescriptor desc); | |||
| TextureGLES(std::shared_ptr<ReactorGLES> reactor, | |||
There was a problem hiding this comment.
Let's document the argument. Something like, "Whether the calling thread has a reactor worker.". Or something that ties the usage to the way the reactor works.
Thinking about this some more, can't this value be implicitly determined using ReactorGLES::CanReactOnCurrentThread?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #165630.
Resolves #164278.
Resolves bdero/flutter_scene#35.
Partly fixes: #160948.