-
Notifications
You must be signed in to change notification settings - Fork 29.5k
Feat: Add brightness export from widgets.dart #169410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@rkishan516 do you know who you'd need to ping to get a review/approval from the team? |
|
I think @dkwingsmt can review. |
dkwingsmt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change itself looks good to me, but I'll need another opinion on whether we should do this. @justinmc can you take a look?
66fab72 to
131fa29
Compare
justinmc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 . I think it makes sense to make Brightness available from widgets in the same way that it is from material.
The widgets library actually already uses Brightness in editable_text.dart, though I'm not sure why it doesn't end up as a transitive dependency but it does in material. If anyone can point me to why, let me know.
@rkishan516 It looks like there are some legitimate failures due to more unused imports now.
131fa29 to
8dadbd2
Compare
|
For the record, I was stumped on how material exported but widgets did not. Thanks to @mdebbar @loic-sharma it's here:
|
justinmc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Feat: Add brightness export from widgets.dart fixes: flutter#169294 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.
Feat: Add brightness export from widgets.dart
fixes: #169294
Pre-launch Checklist
///).