-
Notifications
You must be signed in to change notification settings - Fork 28.9k
fix: "show dialog" functions should allow setting an AnimationStyle #164002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
@nate-thegrate Just wanted to know if there are any updates on this. |
Ooh that's strange. Back in January I was involved with the Flutter team and we had weekly PR triage meetings. IIRC, the On rare occasions, the meetings get postponed or canceled for one reason or another. Hopefully we'll see some progress here soon! |
@dkwingsmt Is there any update regarding this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it somehow missed my queue. LGTM, thank you!
There are some analyzer issues. Running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo the analyzer errors mentioned above. Thank you for the contribution!
am I required to do any kind of changes? |
Yeah, you need to run |
I have applied the formatting |
autosubmit label was removed for flutter/flutter/164002, because - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Why is google testing failing?. Any specific reason? |
fixes issue #154744
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.