Fix: DelegateTransition for cupertino sheet route #164675

rkishan516 · 2025-03-06T04:40:36Z

Fix: DelegateTransition for cupertino sheet route
fixes: #163954

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

justinmc

I'll defer to @MitchellGoodwin on this. I think this probably needs a new test that covers this case at least though.

justinmc · 2025-03-21T20:34:39Z

packages/flutter/test/cupertino/sheet_test.dart

-    final Rect clipRect = tester.getRect(clipRRectFinder);
-    expect(clipRect.center, equals(const Offset(400, 300)));
+    expect(clipRRectFinder, findsNothing);


Why did this change exactly?

Ideally it would be nice if you could write a test that reproduces the error in #163954 and expect that it doesn't happen anymore.

Since after popping this clipper doesn't exist anymore, that's why added this.
But yeah, it will make more sense to add another test which replicates error in #163954

justinmc · 2025-03-21T20:36:22Z

packages/flutter/lib/src/cupertino/sheet.dart

+    if (child != null && secondaryAnimation.isDismissed) {
+      return child;
+    }


Could you explain why this fixes the bug for my own understanding?

After coming back from sheet, if it shows SlideTransition which internally uses RenderFractionalTranslation which doesn't have size because its just a proxy box. So, throws the error as seen in #163954.

Also, it makes sense to just return page, when we have fully popped of from sheet.

MitchellGoodwin · 2025-03-26T17:29:30Z

Hi @rkishan516. Sorry it took me so long to respond to this, but I've been investigating this and related issues. I think the best place to fix this issue is actually in the delegatedTransition logic in the core routes file. If another route with an unusual transition like this is added, it is likely going to cause similar issues.

I was going to open a PR to do that, but it was similar enough to this PR, so I was going to ask if you wanted to do it. I wouldn't want to invalidate your work.

The change would be here, under _buildFlexibleTransitions:

flutter/packages/flutter/lib/src/widgets/routes.dart

Line 1586 in 8297e44

if (receivedTransition == null) {

We'd need to add the check for secondaryAnimation.isDismissed there, so it would look like:

    if (receivedTransition == null || secondaryAnimation.isDismissed) {
      return buildTransitions(context, animation, secondaryAnimation, child);
    }

A test would also have to be added to the routes test in widgets. If you don't want to do that, I can still open my PR, just let me know.

rkishan516 · 2025-03-27T01:04:42Z

Hi @rkishan516. Sorry it took me so long to respond to this, but I've been investigating this and related issues. I think the best place to fix this issue is actually in the delegatedTransition logic in the core routes file. If another route with an unusual transition like this is added, it is likely going to cause similar issues.

I was going to open a PR to do that, but it was similar enough to this PR, so I was going to ask if you wanted to do it. I wouldn't want to invalidate your work.

The change would be here, under _buildFlexibleTransitions:

flutter/packages/flutter/lib/src/widgets/routes.dart

Line 1586 in 8297e44

if (receivedTransition == null) {

We'd need to add the check for secondaryAnimation.isDismissed there, so it would look like:
    if (receivedTransition == null || secondaryAnimation.isDismissed) {
      return buildTransitions(context, animation, secondaryAnimation, child);
    }
A test would also have to be added to the routes test in widgets. If you don't want to do that, I can still open my PR, just let me know.

Hey @MitchellGoodwin, No issues. Yaa, i think that's right approach. I will do the required change and let you know.
Edit :- I have pushed the change.

MitchellGoodwin

LGTM, but this will need a test in routes_test.dart as well.

MitchellGoodwin

LGTM! Just left one nit on the comments.

MitchellGoodwin · 2025-04-01T17:59:50Z

packages/flutter/test/widgets/routes_test.dart

+          ),
+        );
+
+        // Push first page with custom transition builder


Nit: prefer punctuation in comments, so :

Suggested change

// Push first page with custom transition builder

// Push first page with custom transition builder.

MitchellGoodwin · 2025-04-01T18:00:05Z

packages/flutter/test/widgets/routes_test.dart

+        navigator.currentState!.pop();
+        await tester.pumpAndSettle();
+
+        // Verify home is still visible without transitions


Same here with needing the period.

MitchellGoodwin · 2025-04-01T18:00:12Z

packages/flutter/test/widgets/routes_test.dart

+        // Verify home is still visible without transitions
+        expect(find.text('home'), findsOneWidget);
+
+        // Verify the delegated transition is removed


justinmc

LGTM 👍 Thanks for adding the other test, looks good.

…utter#164675)

Roll Flutter from a0b1b32 to 02f13c3 (37 revisions) flutter/flutter@a0b1b32...02f13c3 2025-04-03 engine-flutter-autoroll@skia.org Roll Packages from 07496eb to 4a36dc6 (3 revisions) (flutter/flutter#166542) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from b67e53719e78 to 5f65df75febd (2 revisions) (flutter/flutter#166538) 2025-04-03 magder@google.com Update docs to debug the Android embedder (flutter/flutter#166170) 2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 72562ca93bb5 to d174ec16c3ea (1 revision) (flutter/flutter#166525) 2025-04-03 matej.knopp@gmail.com [macOS] Implement merged UI and platform thread (flutter/flutter#162883) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from f91412f5d89d to b67e53719e78 (1 revision) (flutter/flutter#166527) 2025-04-03 engine-flutter-autoroll@skia.org Roll Packages from 125c117 to 07496eb (31 revisions) (flutter/flutter#166457) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 2be12bc2668b to f91412f5d89d (2 revisions) (flutter/flutter#166517) 2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 2a1a13cc3a91 to 72562ca93bb5 (2 revisions) (flutter/flutter#166514) 2025-04-03 dacoharkes@google.com [native_assets] Roll dependencies (flutter/flutter#166282) 2025-04-03 bruno.leroux@gmail.com Fix read only TextField focus traversal on macOS (flutter/flutter#166056) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from c106d7831592 to 2be12bc2668b (1 revision) (flutter/flutter#166509) 2025-04-03 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from v7PGvypiiWLO8PbsZ... to vYisSsIgqw0mqFRVJ... (flutter/flutter#166508) 2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from b8b4076b1237 to 2a1a13cc3a91 (1 revision) (flutter/flutter#166504) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 75a0ec473181 to c106d7831592 (1 revision) (flutter/flutter#166499) 2025-04-03 34465683+rkishan516@users.noreply.github.com Migrate to Theme.brightnessOf method (flutter/flutter#163950) 2025-04-03 34465683+rkishan516@users.noreply.github.com Fix: Range slider show overlay for both thumbs on hovering one (flutter/flutter#165393) 2025-04-03 victorsanniay@gmail.com Deprecate ExpansionTileController (flutter/flutter#166368) 2025-04-03 kalathiyadimil@gmail.com Add styling parameters in `PopupMenuDivider` (flutter/flutter#164790) 2025-04-03 matanlurey@users.noreply.github.com Fix ISSUE_TEMPLATE Ordering: `10 < 9`, but `10 > 09` (flutter/flutter#166455) 2025-04-03 katelovett@google.com Skip flaking scheduler test (flutter/flutter#166471) 2025-04-02 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#166043) 2025-04-02 yjbanov@google.com [a11y] add SemanticsValidationResult (flutter/flutter#165935) 2025-04-02 58529443+srujzs@users.noreply.github.com Remove unnecessary cache busting mechanism in hot restart (flutter/flutter#166295) 2025-04-02 engine-flutter-autoroll@skia.org Roll Skia from 52cbb917fffd to 75a0ec473181 (21 revisions) (flutter/flutter#166484) 2025-04-02 30870216+gaaclarke@users.noreply.github.com Started pixel aligning hairlines (flutter/flutter#166351) 2025-04-02 47866232+chunhtai@users.noreply.github.com Adds semantics role and adjust semantics for navigation bar (flutter/flutter#162467) 2025-04-02 jacksongardner@google.com Reland "[skwasm] Dynamic Threading" (flutter/flutter#166454) 2025-04-02 dkwingsmt@users.noreply.github.com [dart:ui] Add `Path.addRSuperellipse` (flutter/flutter#166045) 2025-04-02 34465683+rkishan516@users.noreply.github.com Fix: Hero animation for page transition (flutter/flutter#164469) 2025-04-02 34465683+rkishan516@users.noreply.github.com Fix: DelegateTransition for cupertino sheet route (flutter/flutter#164675) 2025-04-02 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from AEdsljKmUiPk92Wvv... to FZdRtNwH7jmADecj6... (flutter/flutter#166383) 2025-04-02 jonahwilliams@google.com [Impeller] cache for text shadows. (flutter/flutter#166228) 2025-04-02 34871572+gmackall@users.noreply.github.com Convert `AppPluginLoaderPlugin` to Kotlin, and add `NativePluginLoaderReflectionBridge` to expose it in Kotlin (flutter/flutter#166027) 2025-04-02 engine-flutter-autoroll@skia.org Roll Dart SDK from 4e1f02bc704f to b8b4076b1237 (7 revisions) (flutter/flutter#166474) 2025-04-02 mit@google.com Update Roadmap (flutter/flutter#166332) 2025-04-02 matanlurey@users.noreply.github.com Update `CODEOWNERS` (flutter/flutter#166444) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose ...

Roll Flutter from a0b1b3253416 to 02f13c37841f (37 revisions) flutter/flutter@a0b1b32...02f13c3 2025-04-03 engine-flutter-autoroll@skia.org Roll Packages from d10d5af to 95f8e65 (3 revisions) (flutter/flutter#166542) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from b67e53719e78 to 5f65df75febd (2 revisions) (flutter/flutter#166538) 2025-04-03 magder@google.com Update docs to debug the Android embedder (flutter/flutter#166170) 2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 72562ca93bb5 to d174ec16c3ea (1 revision) (flutter/flutter#166525) 2025-04-03 matej.knopp@gmail.com [macOS] Implement merged UI and platform thread (flutter/flutter#162883) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from f91412f5d89d to b67e53719e78 (1 revision) (flutter/flutter#166527) 2025-04-03 engine-flutter-autoroll@skia.org Roll Packages from 0d5d57b to d10d5af (31 revisions) (flutter/flutter#166457) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 2be12bc2668b to f91412f5d89d (2 revisions) (flutter/flutter#166517) 2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 2a1a13cc3a91 to 72562ca93bb5 (2 revisions) (flutter/flutter#166514) 2025-04-03 dacoharkes@google.com [native_assets] Roll dependencies (flutter/flutter#166282) 2025-04-03 bruno.leroux@gmail.com Fix read only TextField focus traversal on macOS (flutter/flutter#166056) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from c106d7831592 to 2be12bc2668b (1 revision) (flutter/flutter#166509) 2025-04-03 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from v7PGvypiiWLO8PbsZ... to vYisSsIgqw0mqFRVJ... (flutter/flutter#166508) 2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from b8b4076b1237 to 2a1a13cc3a91 (1 revision) (flutter/flutter#166504) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 75a0ec473181 to c106d7831592 (1 revision) (flutter/flutter#166499) 2025-04-03 34465683+rkishan516@users.noreply.github.com Migrate to Theme.brightnessOf method (flutter/flutter#163950) 2025-04-03 34465683+rkishan516@users.noreply.github.com Fix: Range slider show overlay for both thumbs on hovering one (flutter/flutter#165393) 2025-04-03 victorsanniay@gmail.com Deprecate ExpansionTileController (flutter/flutter#166368) 2025-04-03 kalathiyadimil@gmail.com Add styling parameters in `PopupMenuDivider` (flutter/flutter#164790) 2025-04-03 matanlurey@users.noreply.github.com Fix ISSUE_TEMPLATE Ordering: `10 < 9`, but `10 > 09` (flutter/flutter#166455) 2025-04-03 katelovett@google.com Skip flaking scheduler test (flutter/flutter#166471) 2025-04-02 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#166043) 2025-04-02 yjbanov@google.com [a11y] add SemanticsValidationResult (flutter/flutter#165935) 2025-04-02 58529443+srujzs@users.noreply.github.com Remove unnecessary cache busting mechanism in hot restart (flutter/flutter#166295) 2025-04-02 engine-flutter-autoroll@skia.org Roll Skia from 52cbb917fffd to 75a0ec473181 (21 revisions) (flutter/flutter#166484) 2025-04-02 30870216+gaaclarke@users.noreply.github.com Started pixel aligning hairlines (flutter/flutter#166351) 2025-04-02 47866232+chunhtai@users.noreply.github.com Adds semantics role and adjust semantics for navigation bar (flutter/flutter#162467) 2025-04-02 jacksongardner@google.com Reland "[skwasm] Dynamic Threading" (flutter/flutter#166454) 2025-04-02 dkwingsmt@users.noreply.github.com [dart:ui] Add `Path.addRSuperellipse` (flutter/flutter#166045) 2025-04-02 34465683+rkishan516@users.noreply.github.com Fix: Hero animation for page transition (flutter/flutter#164469) 2025-04-02 34465683+rkishan516@users.noreply.github.com Fix: DelegateTransition for cupertino sheet route (flutter/flutter#164675) 2025-04-02 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from AEdsljKmUiPk92Wvv... to FZdRtNwH7jmADecj6... (flutter/flutter#166383) 2025-04-02 jonahwilliams@google.com [Impeller] cache for text shadows. (flutter/flutter#166228) 2025-04-02 34871572+gmackall@users.noreply.github.com Convert `AppPluginLoaderPlugin` to Kotlin, and add `NativePluginLoaderReflectionBridge` to expose it in Kotlin (flutter/flutter#166027) 2025-04-02 engine-flutter-autoroll@skia.org Roll Dart SDK from 4e1f02bc704f to b8b4076b1237 (7 revisions) (flutter/flutter#166474) 2025-04-02 mit@google.com Update Roadmap (flutter/flutter#166332) 2025-04-02 matanlurey@users.noreply.github.com Update `CODEOWNERS` (flutter/flutter#166444) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose ...

…utter#164675)

Roll Flutter from a0b1b32 to 02f13c3 (37 revisions) flutter/flutter@a0b1b32...02f13c3 2025-04-03 engine-flutter-autoroll@skia.org Roll Packages from 07496eb to 4a36dc6 (3 revisions) (flutter/flutter#166542) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from b67e53719e78 to 5f65df75febd (2 revisions) (flutter/flutter#166538) 2025-04-03 magder@google.com Update docs to debug the Android embedder (flutter/flutter#166170) 2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 72562ca93bb5 to d174ec16c3ea (1 revision) (flutter/flutter#166525) 2025-04-03 matej.knopp@gmail.com [macOS] Implement merged UI and platform thread (flutter/flutter#162883) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from f91412f5d89d to b67e53719e78 (1 revision) (flutter/flutter#166527) 2025-04-03 engine-flutter-autoroll@skia.org Roll Packages from 125c117 to 07496eb (31 revisions) (flutter/flutter#166457) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 2be12bc2668b to f91412f5d89d (2 revisions) (flutter/flutter#166517) 2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 2a1a13cc3a91 to 72562ca93bb5 (2 revisions) (flutter/flutter#166514) 2025-04-03 dacoharkes@google.com [native_assets] Roll dependencies (flutter/flutter#166282) 2025-04-03 bruno.leroux@gmail.com Fix read only TextField focus traversal on macOS (flutter/flutter#166056) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from c106d7831592 to 2be12bc2668b (1 revision) (flutter/flutter#166509) 2025-04-03 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from v7PGvypiiWLO8PbsZ... to vYisSsIgqw0mqFRVJ... (flutter/flutter#166508) 2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from b8b4076b1237 to 2a1a13cc3a91 (1 revision) (flutter/flutter#166504) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 75a0ec473181 to c106d7831592 (1 revision) (flutter/flutter#166499) 2025-04-03 34465683+rkishan516@users.noreply.github.com Migrate to Theme.brightnessOf method (flutter/flutter#163950) 2025-04-03 34465683+rkishan516@users.noreply.github.com Fix: Range slider show overlay for both thumbs on hovering one (flutter/flutter#165393) 2025-04-03 victorsanniay@gmail.com Deprecate ExpansionTileController (flutter/flutter#166368) 2025-04-03 kalathiyadimil@gmail.com Add styling parameters in `PopupMenuDivider` (flutter/flutter#164790) 2025-04-03 matanlurey@users.noreply.github.com Fix ISSUE_TEMPLATE Ordering: `10 < 9`, but `10 > 09` (flutter/flutter#166455) 2025-04-03 katelovett@google.com Skip flaking scheduler test (flutter/flutter#166471) 2025-04-02 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#166043) 2025-04-02 yjbanov@google.com [a11y] add SemanticsValidationResult (flutter/flutter#165935) 2025-04-02 58529443+srujzs@users.noreply.github.com Remove unnecessary cache busting mechanism in hot restart (flutter/flutter#166295) 2025-04-02 engine-flutter-autoroll@skia.org Roll Skia from 52cbb917fffd to 75a0ec473181 (21 revisions) (flutter/flutter#166484) 2025-04-02 30870216+gaaclarke@users.noreply.github.com Started pixel aligning hairlines (flutter/flutter#166351) 2025-04-02 47866232+chunhtai@users.noreply.github.com Adds semantics role and adjust semantics for navigation bar (flutter/flutter#162467) 2025-04-02 jacksongardner@google.com Reland "[skwasm] Dynamic Threading" (flutter/flutter#166454) 2025-04-02 dkwingsmt@users.noreply.github.com [dart:ui] Add `Path.addRSuperellipse` (flutter/flutter#166045) 2025-04-02 34465683+rkishan516@users.noreply.github.com Fix: Hero animation for page transition (flutter/flutter#164469) 2025-04-02 34465683+rkishan516@users.noreply.github.com Fix: DelegateTransition for cupertino sheet route (flutter/flutter#164675) 2025-04-02 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from AEdsljKmUiPk92Wvv... to FZdRtNwH7jmADecj6... (flutter/flutter#166383) 2025-04-02 jonahwilliams@google.com [Impeller] cache for text shadows. (flutter/flutter#166228) 2025-04-02 34871572+gmackall@users.noreply.github.com Convert `AppPluginLoaderPlugin` to Kotlin, and add `NativePluginLoaderReflectionBridge` to expose it in Kotlin (flutter/flutter#166027) 2025-04-02 engine-flutter-autoroll@skia.org Roll Dart SDK from 4e1f02bc704f to b8b4076b1237 (7 revisions) (flutter/flutter#166474) 2025-04-02 mit@google.com Update Roadmap (flutter/flutter#166332) 2025-04-02 matanlurey@users.noreply.github.com Update `CODEOWNERS` (flutter/flutter#166444) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose ...

Fix: DelegateTransition for cupertino sheet route fixes: flutter#163954 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing.

Roll Flutter from a0b1b32 to 02f13c3 (37 revisions) flutter/flutter@a0b1b32...02f13c3 2025-04-03 engine-flutter-autoroll@skia.org Roll Packages from 07496eb to 4a36dc6 (3 revisions) (flutter/flutter#166542) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from b67e53719e78 to 5f65df75febd (2 revisions) (flutter/flutter#166538) 2025-04-03 magder@google.com Update docs to debug the Android embedder (flutter/flutter#166170) 2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 72562ca93bb5 to d174ec16c3ea (1 revision) (flutter/flutter#166525) 2025-04-03 matej.knopp@gmail.com [macOS] Implement merged UI and platform thread (flutter/flutter#162883) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from f91412f5d89d to b67e53719e78 (1 revision) (flutter/flutter#166527) 2025-04-03 engine-flutter-autoroll@skia.org Roll Packages from 125c117 to 07496eb (31 revisions) (flutter/flutter#166457) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 2be12bc2668b to f91412f5d89d (2 revisions) (flutter/flutter#166517) 2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 2a1a13cc3a91 to 72562ca93bb5 (2 revisions) (flutter/flutter#166514) 2025-04-03 dacoharkes@google.com [native_assets] Roll dependencies (flutter/flutter#166282) 2025-04-03 bruno.leroux@gmail.com Fix read only TextField focus traversal on macOS (flutter/flutter#166056) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from c106d7831592 to 2be12bc2668b (1 revision) (flutter/flutter#166509) 2025-04-03 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from v7PGvypiiWLO8PbsZ... to vYisSsIgqw0mqFRVJ... (flutter/flutter#166508) 2025-04-03 engine-flutter-autoroll@skia.org Roll Dart SDK from b8b4076b1237 to 2a1a13cc3a91 (1 revision) (flutter/flutter#166504) 2025-04-03 engine-flutter-autoroll@skia.org Roll Skia from 75a0ec473181 to c106d7831592 (1 revision) (flutter/flutter#166499) 2025-04-03 34465683+rkishan516@users.noreply.github.com Migrate to Theme.brightnessOf method (flutter/flutter#163950) 2025-04-03 34465683+rkishan516@users.noreply.github.com Fix: Range slider show overlay for both thumbs on hovering one (flutter/flutter#165393) 2025-04-03 victorsanniay@gmail.com Deprecate ExpansionTileController (flutter/flutter#166368) 2025-04-03 kalathiyadimil@gmail.com Add styling parameters in `PopupMenuDivider` (flutter/flutter#164790) 2025-04-03 matanlurey@users.noreply.github.com Fix ISSUE_TEMPLATE Ordering: `10 < 9`, but `10 > 09` (flutter/flutter#166455) 2025-04-03 katelovett@google.com Skip flaking scheduler test (flutter/flutter#166471) 2025-04-02 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#166043) 2025-04-02 yjbanov@google.com [a11y] add SemanticsValidationResult (flutter/flutter#165935) 2025-04-02 58529443+srujzs@users.noreply.github.com Remove unnecessary cache busting mechanism in hot restart (flutter/flutter#166295) 2025-04-02 engine-flutter-autoroll@skia.org Roll Skia from 52cbb917fffd to 75a0ec473181 (21 revisions) (flutter/flutter#166484) 2025-04-02 30870216+gaaclarke@users.noreply.github.com Started pixel aligning hairlines (flutter/flutter#166351) 2025-04-02 47866232+chunhtai@users.noreply.github.com Adds semantics role and adjust semantics for navigation bar (flutter/flutter#162467) 2025-04-02 jacksongardner@google.com Reland "[skwasm] Dynamic Threading" (flutter/flutter#166454) 2025-04-02 dkwingsmt@users.noreply.github.com [dart:ui] Add `Path.addRSuperellipse` (flutter/flutter#166045) 2025-04-02 34465683+rkishan516@users.noreply.github.com Fix: Hero animation for page transition (flutter/flutter#164469) 2025-04-02 34465683+rkishan516@users.noreply.github.com Fix: DelegateTransition for cupertino sheet route (flutter/flutter#164675) 2025-04-02 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from AEdsljKmUiPk92Wvv... to FZdRtNwH7jmADecj6... (flutter/flutter#166383) 2025-04-02 jonahwilliams@google.com [Impeller] cache for text shadows. (flutter/flutter#166228) 2025-04-02 34871572+gmackall@users.noreply.github.com Convert `AppPluginLoaderPlugin` to Kotlin, and add `NativePluginLoaderReflectionBridge` to expose it in Kotlin (flutter/flutter#166027) 2025-04-02 engine-flutter-autoroll@skia.org Roll Dart SDK from 4e1f02bc704f to b8b4076b1237 (7 revisions) (flutter/flutter#166474) 2025-04-02 mit@google.com Update Roadmap (flutter/flutter#166332) 2025-04-02 matanlurey@users.noreply.github.com Update `CODEOWNERS` (flutter/flutter#166444) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose ...

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels Mar 6, 2025

dkwingsmt requested a review from MitchellGoodwin March 12, 2025 18:38

justinmc reviewed Mar 21, 2025

View reviewed changes

rkishan516 force-pushed the cupertino-sheet-route-popup branch 2 times, most recently from f99e121 to 4f575b2 Compare March 26, 2025 03:00

rkishan516 force-pushed the cupertino-sheet-route-popup branch from 4f575b2 to b391de1 Compare March 27, 2025 01:05

github-actions bot added the f: routes Navigator, Router, and related APIs. label Mar 27, 2025

rkishan516 mentioned this pull request Mar 27, 2025

Fix: CupertinoSheetTransition moves SystemUIOverlayStyle to outside of delegatedTransition and only changes top bar #164680

Merged

9 tasks

MitchellGoodwin reviewed Mar 27, 2025

View reviewed changes

rkishan516 force-pushed the cupertino-sheet-route-popup branch from b391de1 to 0f597d8 Compare March 27, 2025 23:40

MitchellGoodwin approved these changes Apr 1, 2025

View reviewed changes

Fix: DelegateTransition for cupertino sheet route

83d8819

rkishan516 force-pushed the cupertino-sheet-route-popup branch from 2ddfa25 to 83d8819 Compare April 2, 2025 00:25

justinmc approved these changes Apr 2, 2025

View reviewed changes

MitchellGoodwin added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 2, 2025

auto-submit bot added this pull request to the merge queue Apr 2, 2025

matanlurey removed this pull request from the merge queue due to a manual request Apr 2, 2025

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 2, 2025

MitchellGoodwin added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 2, 2025

auto-submit bot added this pull request to the merge queue Apr 2, 2025

Merged via the queue into flutter:master with commit 4503f2f Apr 2, 2025
76 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 2, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025

4503f2f Fix: DelegateTransition for cupertino sheet route (flutter/fl…

dad8a89

…utter#164675)

engine-flutter-autoroll mentioned this pull request Apr 3, 2025

Roll Flutter from a0b1b3253416 to 275ad8da5b97 (30 revisions) flutter/packages#8987

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025

4503f2f Fix: DelegateTransition for cupertino sheet route (flutter/fl…

05f5df9

…utter#164675)

engine-flutter-autoroll mentioned this pull request Apr 3, 2025

Roll Flutter from a0b1b3253416 to 6df932243c12 (31 revisions) flutter/packages#8989

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025

4503f2f Fix: DelegateTransition for cupertino sheet route (flutter/fl…

2b0183d

…utter#164675)

engine-flutter-autoroll mentioned this pull request Apr 3, 2025

Roll Flutter from a0b1b3253416 to 3237222b6211 (33 revisions) flutter/packages#8991

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025

4503f2f Fix: DelegateTransition for cupertino sheet route (flutter/fl…

723f18b

…utter#164675)

engine-flutter-autoroll mentioned this pull request Apr 3, 2025

Roll Flutter from a0b1b3253416 to 269d544a9b9a (34 revisions) flutter/packages#8993

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025

4503f2f Fix: DelegateTransition for cupertino sheet route (flutter/fl…

c6bf64f

…utter#164675)

engine-flutter-autoroll mentioned this pull request Apr 3, 2025

Roll Flutter from a0b1b3253416 to 73590fb0d2b7 (35 revisions) flutter/packages#8994

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025

4503f2f Fix: DelegateTransition for cupertino sheet route (flutter/fl…

0ed735b

…utter#164675)

engine-flutter-autoroll mentioned this pull request Apr 3, 2025

Roll Flutter from a0b1b3253416 to ceec33f16bea (36 revisions) flutter/packages#8995

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 3, 2025

4503f2f Fix: DelegateTransition for cupertino sheet route (flutter/fl…

d0fbf27

…utter#164675)

engine-flutter-autoroll mentioned this pull request Apr 3, 2025

Roll Flutter from a0b1b3253416 to 02f13c37841f (37 revisions) flutter/packages#8996

Merged

This was referenced Apr 10, 2025

Modal bottom sheet is not dismissible when using FadeForwardsPageTransitionsBuilder #165681

Closed

fix barrier overlap after and during FadeForwardsPageTransitionsBuilder transition animation #165726

Closed

Piinks mentioned this pull request Apr 18, 2025

Flutter Notable Commits - 2025 #161460

Open

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

4503f2f Fix: DelegateTransition for cupertino sheet route (flutter/fl…

6607eb6

…utter#164675)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

4503f2f Fix: DelegateTransition for cupertino sheet route (flutter/fl…

164b91f

…utter#164675)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

4503f2f Fix: DelegateTransition for cupertino sheet route (flutter/fl…

01c31e0

…utter#164675)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix: DelegateTransition for cupertino sheet route #164675

Fix: DelegateTransition for cupertino sheet route #164675

Uh oh!

rkishan516 commented Mar 6, 2025 •

edited

Loading

Uh oh!

justinmc left a comment

Uh oh!

justinmc Mar 21, 2025

Uh oh!

rkishan516 Mar 22, 2025

Uh oh!

justinmc Mar 21, 2025

Uh oh!

rkishan516 Mar 22, 2025

Uh oh!

MitchellGoodwin commented Mar 26, 2025

Uh oh!

rkishan516 commented Mar 27, 2025 •

edited

Loading

Uh oh!

MitchellGoodwin left a comment

Uh oh!

MitchellGoodwin left a comment

Uh oh!

MitchellGoodwin Apr 1, 2025

Uh oh!

MitchellGoodwin Apr 1, 2025

Uh oh!

MitchellGoodwin Apr 1, 2025

Uh oh!

justinmc left a comment

Uh oh!

Uh oh!

Uh oh!

	// Push first page with custom transition builder
	// Push first page with custom transition builder.

Fix: DelegateTransition for cupertino sheet route #164675

Fix: DelegateTransition for cupertino sheet route #164675

Uh oh!

Conversation

rkishan516 commented Mar 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

rkishan516 Mar 22, 2025

Choose a reason for hiding this comment

Uh oh!

justinmc Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

rkishan516 Mar 22, 2025

Choose a reason for hiding this comment

Uh oh!

MitchellGoodwin commented Mar 26, 2025

Uh oh!

rkishan516 commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MitchellGoodwin left a comment

Choose a reason for hiding this comment

Uh oh!

MitchellGoodwin left a comment

Choose a reason for hiding this comment

Uh oh!

MitchellGoodwin Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

MitchellGoodwin Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

MitchellGoodwin Apr 1, 2025

Choose a reason for hiding this comment

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rkishan516 commented Mar 6, 2025 •

edited

Loading

rkishan516 commented Mar 27, 2025 •

edited

Loading